Skip to content

sof-kernel-log-check: fix a ignore_str for usb errors - #624

Merged
marc-hb merged 1 commit into
thesofproject:masterfrom
fredoh9:fix/usb18_error
Mar 6, 2021
Merged

marc-hb merged 1 commit into
thesofproject:masterfrom
fredoh9:fix/usb18_error

Conversation

@fredoh9

@fredoh9 fredoh9 commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

WHL UP Extreme has this errors while doing suspend/resume, need to fix
regular expression to ignore this.

[ 6876.560685] usb 1-8: device not accepting address 11, error -71
[ 6877.088731] usb 1-8: device not accepting address 12, error -71

This works with previous error pattern,
[ 1905.017875] kernel: usb 1-2.4: device not accepting address 4, error -71

Signed-off-by: Fred Oh fred.oh@intel.com

fixes: #606

WHL UP Extreme has this errors while doing suspend/resume, need to fix
regular expression to ignore this.

[ 6876.560685] usb 1-8: device not accepting address 11, error -71
[ 6877.088731] usb 1-8: device not accepting address 12, error -71

This works with previous error pattern,
[ 1905.017875] kernel: usb 1-2.4: device not accepting address 4, error -71

Signed-off-by: Fred Oh <fred.oh@intel.com>
@fredoh9
fredoh9 requested a review from a team as a code owner March 3, 2021 23:51

@ranj063 ranj063 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. Thanks @fredoh9

@marc-hb

marc-hb commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

@fredoh9 can you run lsusb -t and share what device this is?

.+. was a surprising equivalent to .{2,}, that threw me off. It was introduced in commit b513877 / PR #549 by ... @fredoh9 :-)
So, before PR #549 1-2 was ignored and 1-23 was not.
After PR #549 1-2 was not ignored and 1-23 was. I guess it was not intended?

After this both 1-2 and 1-23 are ignored - good at last?

@marc-hb
marc-hb merged commit 29888e2 into thesofproject:master Mar 6, 2021
@marc-hb marc-hb added area:non-audio Failure False positives: failing when we don't want to area:dmesg filter labels Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:non-audio Failure False positives: failing when we don't want to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] filter out USB 1.8 error on Up Extreme

4 participants