Skip to content

sof-kernel-log-check: fix to filter out USB3.1 suspend/resume error - #549

Merged
aiChaoSONG merged 1 commit into
thesofproject:masterfrom
fredoh9:fix/tgl-usb-error
Dec 8, 2020
Merged

aiChaoSONG merged 1 commit into
thesofproject:masterfrom
fredoh9:fix/tgl-usb-error

Conversation

@fredoh9

@fredoh9 fredoh9 commented Dec 8, 2020 •

Copy link
Copy Markdown
Contributor

'.' is single charactor. Template string doesn't need error number
to have.

Signed-off-by: Fred Oh fred.oh@linux.intel.com

Still test will be failed due to this errors without this fix.

[   28.970627] kernel: usb 3-10: device descriptor read/64, error -71
[   29.193611] kernel: usb 3-10: device descriptor read/64, error -71
[   29.526684] kernel: usb 3-10: device descriptor read/64, error -71
[   29.746289] kernel: usb 3-10: device descriptor read/64, error -71
[   30.887534] kernel: usb 3-10: device not accepting address 13, error -71
[   31.415512] kernel: usb 3-10: device not accepting address 14, error -71

@fredoh9
fredoh9 requested a review from a team as a code owner December 8, 2020 02:27

@aiChaoSONG aiChaoSONG left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredoh9 Let have a quick fix and merge

Comment thread tools/sof-kernel-log-check.sh Resolved
Refine ignore_str to match correctly.

Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
marc-hb
marc-hb previously requested changes Dec 8, 2020

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing .+ is misleading because AFAIK we don't perform full line matching, can you please use fake_kern_error and re-test without it?

It still works but generates the confusion that we perform full line matching and will be copied by future users.

@aiChaoSONG

aiChaoSONG commented Dec 8, 2020 •

Copy link
Copy Markdown

@marc-hb I have tested old RE with a single dot, confirmed not work.

Edit: this is for SDW PV, so I am afraid it should be merged currently, maybe we can re-fix later?

@aiChaoSONG
aiChaoSONG dismissed marc-hb’s stale review December 8, 2020 05:40

dismiss for sdw pv

@aiChaoSONG
aiChaoSONG merged commit b513877 into thesofproject:master Dec 8, 2020
@marc-hb

marc-hb commented Dec 8, 2020

Copy link
Copy Markdown
Collaborator

@aiChaoSONG

The TRAILING (last) .+ is misleading

If the TRAILING .+ was required, many of the other filters wouldn't work.

@fredoh9 can you test and submit a fixup removing the trailing .+?

@marc-hb

marc-hb commented Mar 6, 2021 •

Copy link
Copy Markdown
Collaborator

I think the .+. in the middle was a bug, fixed in #624

@marc-hb marc-hb added the area:non-audio Failure False positives: failing when we don't want to label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:non-audio Failure False positives: failing when we don't want to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants