Repository navigation
plan-feature: lift citation pre-flight, surface gate, hypothesis interview, dual-reviewer Phase 5 - #37
Merged
Conversation
Lifted from kendo .claude/skills/plan-feature/scripts (2026-07-28). The resolver is unchanged in behaviour; the test suite now builds its own fixture repository in a temp directory instead of resolving against the host repo, so it passes in any consumer. Generalised: path prefixes and symbol search roots are configurable via CITATION_PATH_PREFIXES / CITATION_SEARCH_ROOTS, with a whole-repo fallback (prose and vendor trees excluded) when no conventional source tree exists. Issue-key references in the comments became "the calibration plan". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
Lifted from kendo (2026-08-27): references/surface-questions.md is new; quality-gates.md gains the Phase 1.6 security gate, its sycophancy guards, and the Planning Evidence persistence rule. Generalised: worked examples use neutral record/widget names; the prompt-injection guard, billing provider, operator log and static-analysis rule package are described by role, not by product; the escalation ladder cites "the repo's standing rule for convention enforcement" instead of an ADR number. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
…viewer Phase 5 Lifted from kendo .claude/skills/plan-feature (2026-08-27): - Phase 1.4 pre-flight citation verification via scripts/verify-citations.sh - Phase 1.6 Security & Cost Surface gate - Phase 2 rewritten as interview-with-hypotheses (dependency order, self-serve before asking, live glossary check) - Phase 4d rows for Planning Evidence, Sweep Inventory, Surface, red cases, hedge parentheticals - Phase 5 spawns plan-reviewer + surface-reviewer in parallel, then hands off to /wireframe; the inline 5b/5c wireframe steps are gone - plan-template.md: Planning Evidence, Sweep Inventory, Security & Cost Surface sections, red-case test lines, docs-mirror row - module-shape-lens.md: shallow-detection test, reckoning column - anti-patterns.md: settled-recommendation rule, citation calibration Generalised: the root CONTEXT.md glossary read is conditional on the file existing; arch-test file names became "the repo's architecture rules"; calibration stories drop issue keys and product paths; the docs mirror is "an LLM-facing text export, if the repo ships one"; acceptance-reviewer is no longer cited as a PLAN.md consumer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
This was referenced Sep 2, 2026
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Re-sync
plan-featurewith kendo's.claude/skills/plan-featureas of 2026-08-27 (catalog-resync plan, rowplan-feature). PRs #4/#5 lifted the older version withreferences/; this PR lifts everything added since.What
scripts/verify-citations.shandscripts/verify-citations.test.sh(executable). The test suite builds its own fixture repo in a temp dir, so it passes in any consumer (32 assertions, green).references/surface-questions.md, shared with thesurface-revieweragent.quality-gates.mdbecomes three gates.## Planning Evidence,## Sweep Inventory,## Security & Cost Surface(six sub-rows); red-case lines in Testing Strategy; Site Docs Sync becomes an Update/N-A row table with a docs-mirror row.plan-reviewer+surface-reviewerin parallel (single message), then hands off to/wireframe. The inline 5b/5c wireframe steps are removed.Generalised
CONTEXT.mdglossary read: "if the repo has aCONTEXT.mdglossary at root, read it".deptrac.yaml/tests/Arch/*.php/domain-structure.spec.tslists: kept the catalog's "the repo's architecture rules" wording.Backlog.vue:560,GithubAppService,IssueWatcher) became neutral descriptions or<Vendor>placeholders.phpstan-warroom-rulesbecame "the repo's standing rule for convention enforcement"; L2 is "static-analysis rule".PromptInjectionGuard::FRAMEWORK_TAGS, Stripe, Nightwatch: described by role (prompt-injection guard's framework-tag constant, billing provider, operator log).site/public/llms-full.txt: "an LLM-facing text export of the docs, if the repo ships one".CITATION_SEARCH_ROOTS/CITATION_PATH_PREFIXES, whole-repo fallback with prose/vendor exclusions.acceptance-reviewerdropped from the PLAN.md consumer list;precedent-reviewerandsurface-revieweradded.Out of scope
references/plan-directory.md(kendo'sdocs/bugs/root) belongs to thereview-branchrow.references/decisions-template.md: placeholder-only difference, no drift.kendo://issues/{key}read plus the key-vs-ID warning.Test plan
bash skills/plan-feature/scripts/verify-citations.test.sh— OK: all 32 assertions passedgrep -rn -i 'kendo\|KD-[0-9]\|CRIT-\|script\.nl\|warroom\|war room\|phpstan\|knip' skills/plan-feature— only pre-existing product/MCP-tool names (kendo://,mcp__kendo__*, "Kendo board") and untouchedplan-directory.mdexamplesgrep -rn 'acceptance-reviewer\|simplicity-reviewer\|silent-failure-hunter\|efficiency-hunter\|task-alignment-reviewer' skills/plan-feature— emptyreferences/link in SKILL.md resolves🤖 Generated with Claude Code
https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7