Skip to content

wireframe: lift references, zero-UI guard, resume mode, wireframe-reviewer self-gate - #39

Merged
jasperboerhof merged 2 commits into
mainfrom
lift/wireframe
Sep 2, 2026
Merged

jasperboerhof merged 2 commits into
mainfrom
lift/wireframe

Conversation

@jasperboerhof

Copy link
Copy Markdown
Contributor

Why

Re-sync wireframe with kendo's .claude/skills/wireframe as of 2026-07-27 (catalog-resync plan, row wireframe).

What

  • references/wireframes-template.md (new): the Document Structure moves out of SKILL.md. Exactly 5 sections, per-section rules, token precision table, named font-size example, "what does NOT belong" table.
  • references/issue-board.md (new): worked example of a full board wireframe, with a header note explaining which sections are design-documentation extras.
  • references/anti-patterns.md (new): the ten reviewer-breaking failure modes, moved out of SKILL.md.
  • Step 1a zero-UI-scope guard: backend-only plans stop with one line instead of invented screens.
  • Step 1b resume vs restart: an existing substantive WIREFRAMES.md is completed, not overwritten.
  • Step 5 self-gate with wireframe-reviewer (≥ 7), then the /task-writer handoff question. Moved here from plan-feature Phase 5b/5c (PR plan-feature: lift citation pre-flight, surface gate, hypothesis interview, dual-reviewer Phase 5 #37).
  • acceptance-reviewer removed as a downstream consumer. wireframe-reviewer is the only gate; the implementer is the real audience afterwards.

Generalised

  • /kendo-design-system → "a design-system skill if the project provides one, otherwise read the utility/theme config".
  • Kendo page paths in Step 2 (apps/*/domains/*/pages/Overview.vue, SimpleBadge + tint-*, central-app inline calls) → the catalog's generic search list plus "match the state pattern of the area you're wireframing".
  • UnoCSS attributify tokens (bg-kendo-surface, c-kendo-text-dim, b="1 solid kendo-border") → design-token shapes with a "substitute the project's names" note.
  • app-boundaries.spec.ts → "the repo's app-boundary architecture test, if it has one".
  • Worked example: KD- → XX- (read as {{ISSUE_KEY_PREFIX}}-, same width so the ASCII art stays aligned), --kendo-red → --brand, kendo.css → theme.css, the logo and a real person's name replaced, "kendo's personality" → "the product's personality". Lane names (Todo / In Progress / Review / Done) were already generic and are kept.

Out of scope

  • agents/wireframe-reviewer.md (next PR in this cluster).
  • Kendo's .claude/REVIEWERS.md citation (decision D2).
  • README.md untouched.

Test plan

  • grep -rn -i 'kendo\|KD-[0-9]\|CRIT-\|script\.nl\|warroom\|war room\|phpstan\|knip' skills/wireframe — empty
  • grep -rn 'acceptance-reviewer\|simplicity-reviewer\|silent-failure-hunter\|efficiency-hunter\|task-alignment-reviewer' skills/wireframe — empty
  • Every references/ link in SKILL.md resolves; plan-directory.md cross-link unchanged
  • Worked-example ASCII rows keep their original line lengths after substitution

🤖 Generated with Claude Code

https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7

jasperboerhof and others added 2 commits September 2, 2026 19:42
…s references

Lifted from kendo .claude/skills/wireframe/references (2026-07-27). The
inline Document Structure moves out of SKILL.md into
references/wireframes-template.md; issue-board.md is the worked example;
anti-patterns.md carries the reviewer-breaking failure modes.

Generalised: UnoCSS attributify tokens became design-token shapes with the
project's own names to be substituted; the named font-size table is an
example to grep-verify, not a fixed list; app-boundaries.spec.ts became
"the repo's app-boundary architecture test, if it has one"; the worked
example uses XX-#### issue keys, a neutral brand token and logo, and no
real person's name.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
…-reviewer

Lifted from kendo .claude/skills/wireframe/SKILL.md (2026-07-27):
- Step 1a zero-UI-scope guard (stop with one line on backend-only plans)
- Step 1b resume vs restart when WIREFRAMES.md already exists
- Step 4 points at references/wireframes-template.md instead of inlining
  the document structure
- Step 5 self-gate with wireframe-reviewer, moved here from plan-feature
- acceptance-reviewer removed as a downstream consumer; wireframe-reviewer
  is the only gate the spec passes

Generalised: /kendo-design-system became "a design-system skill if the
project provides one, else the utility config"; Step 2 keeps the catalog's
generic search list instead of kendo page paths.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
@jasperboerhof jasperboerhof added the Agent Review Requested Ask an agent to review this PR label Sep 2, 2026
@jasperboerhof
jasperboerhof merged commit 0605452 into main Sep 2, 2026
1 check passed
@jasperboerhof
jasperboerhof deleted the lift/wireframe branch September 7, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Review Requested Ask an agent to review this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant