Skip to content

wireframe-reviewer: append review notes, sole gate, generalised arch-test checks - #40

Merged
jasperboerhof merged 1 commit into
mainfrom
lift/wireframe-reviewer
Sep 2, 2026
Merged

jasperboerhof merged 1 commit into
mainfrom
lift/wireframe-reviewer

Conversation

@jasperboerhof

Copy link
Copy Markdown
Contributor

Why

Re-sync agents/wireframe-reviewer.md with kendo's .claude/agents/wireframe-reviewer.md as of 2026-07-27 (catalog-resync plan, row agents/wireframe-reviewer.md).

What

  • Step 9: append a ## Review Notes section (Reviewed / Score / Result, Top Issues, AC Traceability) to WIREFRAMES.md. A re-run replaces the section instead of appending a second one.
  • Reframed as the sole gate: the intro says no pre-PR reviewer greps the spec against shipped templates, so this reviewer is the last gate. Step 7 wording no longer promises a downstream acceptance check.
  • Step 5 frontend architecture compliance: app-boundary rules (multi-area components must live in shared) and domain-structure rules (required domain files, store-factory exceptions), with an explicit skip when the repo has no frontend arch tests.
  • tools gains Edit so Step 9 can run; rules and constraints updated (read-only except that one Edit; budget 22 tool calls).

Generalised

  • frontend/tests/js/architecture/app-boundaries.spec.ts / domain-structure.spec.ts → "the repo's frontend architecture tests, if any (e.g. app-boundary and domain-structure rules)" with generic glob hints.
  • @central/ / @tenant/ / @shared/ → "app areas" and "the shared directory"; CUSTOM_STORE_EXCEPTIONS → "the exceptions list".
  • Token wording (bg-kendo-surface, UnoCSS attributify greps) keeps the catalog's design-token phrasing, per the item instructions.
  • acceptance-reviewer and task-alignment-reviewer references removed; plans have plan-reviewer + surface-reviewer, tasks have a self-administered coverage gate.

Out of scope

Test plan

  • grep -rn -i 'kendo\|KD-[0-9]\|CRIT-\|script\.nl\|warroom\|war room\|phpstan\|knip' agents/wireframe-reviewer.md — empty
  • grep -rn 'acceptance-reviewer\|simplicity-reviewer\|silent-failure-hunter\|efficiency-hunter\|task-alignment-reviewer' agents/wireframe-reviewer.md — empty
  • Step numbering, report format, and scoring guide unchanged from the catalog version apart from the additions above

🤖 Generated with Claude Code

https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7

…test checks

Lifted from kendo .claude/agents/wireframe-reviewer.md (2026-07-27):
- Step 9 appends a Review Notes section (Top Issues, AC Traceability) to
  WIREFRAMES.md; re-runs replace it instead of stacking
- Reframed as the only gate the wireframe passes; no acceptance-reviewer
  downstream, the implementer is the audience
- Step 5 frontend architecture checks (app-boundary and domain-structure
  rules) with a skip when the repo has none
- Edit added to the tools list so Step 9 can run; tool budget 22

Generalised: frontend/tests/js/architecture/app-boundaries.spec.ts and
domain-structure.spec.ts became "the repo's frontend architecture tests,
if any"; @central/@tenant became "app areas"; UnoCSS token wording keeps
the catalog's design-token phrasing.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
@jasperboerhof jasperboerhof added the Agent Review Requested Ask an agent to review this PR label Sep 2, 2026
@jasperboerhof
jasperboerhof merged commit d8ee2d9 into main Sep 2, 2026
1 check passed
@jasperboerhof
jasperboerhof deleted the lift/wireframe-reviewer branch September 7, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agent Review Requested Ask an agent to review this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant