Repository navigation
plan-reviewer: module-shape re-check, surface delegation, check-or-create review notes - #41
Merged
Merged
Conversation
The catalog copy was the only file in the repo with CRLF terminators. Content unchanged; separated out so the lift commit diffs cleanly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
…eate review notes Lifted from kendo .claude/agents/plan-reviewer.md (2026-07-27): - Step 2b re-applies the module-shape lens independently of the author's verdict; any Module-Shape FAIL caps the score at 6 - Surface analysis delegated to surface-reviewer (runs in parallel at plan-feature Phase 5); a missing section is reported, not scored - Step 6 appends "### Plan Review" under a check-or-create "## Review Notes" heading, never overwriting surface-reviewer's sibling subsection - Convention Scan table gains the Module Shape row; tool budget 25 - Kendo Repo Quick Reference section not carried over Generalised: ~/Code/kendo paths became the catalog's existing CLAUDE.md discovery and arch-test discovery steps; the GithubAppService precedent cite became "the vendor-app service split recorded under Calibration in module-shape-lens.md"; "pass deptrac" became "pass layer rules". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Re-sync
agents/plan-reviewer.mdwith kendo's.claude/agents/plan-reviewer.mdas of 2026-07-27 (catalog-resync plan, rowagents/plan-reviewer.md).What
## Security & Cost Surfacesection is graded bysurface-reviewer, not here. A missing section is mentioned once in Summary so the parent re-spawns surface-reviewer; it does not affect the convention score.## Review Notes, then append a### Plan Reviewsubsection. Never adds a second heading, never overwrites### Surface Review (plan-time). Same protocol as surface-reviewer's Step 4, because both run in parallel.Module Shaperow; tool budget 25.Generalised
~/Code/kendo/CLAUDE.mdlist in Step 1 → the catalog's existing CLAUDE.md discovery step (unchanged).~/Code/kendo/backend/tests/Arch/*.phpcats in the arch-test step → the catalog's existing generic discovery (unchanged)..claude/skills/plan-feature/references/module-shape-lens.mdcited by its consumer-relative path (matches howsurface-reviewercites its references).GithubAppService" → "the vendor-app service split recorded under Calibration inmodule-shape-lens.md" (that calibration was generalised in PR plan-feature: lift citation pre-flight, surface gate, hypothesis interview, dual-reviewer Phase 5 #37).Out of scope
model:staysopus(catalog) while kendo runssonnet. Not in the row instructions; flagging for a decision.Test plan
grep -rn -i 'kendo\|KD-[0-9]\|CRIT-\|script\.nl\|warroom\|war room\|phpstan\|knip' agents/plan-reviewer.md— one pre-existing hit: the generic tool list in Step 2c ("PHPStan, Pest Arch, ESLint custom rules, dependency-cruiser")grep -rn 'acceptance-reviewer\|simplicity-reviewer\|silent-failure-hunter\|efficiency-hunter\|task-alignment-reviewer' agents/plan-reviewer.md— emptygit diff origin/main..HEAD~1 --ignore-all-space --statis empty for the normalisation commit; content diff is 45+/7-🤖 Generated with Claude Code
https://claude.ai/code/session_01UX7YHkAamvBe8Hh66f95b7