Repository navigation
Phase 4 (stacked on PR #4): factor plan-feature inline content into 5 reference files - #5
Merged
Merged
Conversation
…kendo)
Catalog plan-feature was 544 lines with all the templates and rules
inline; kendo factored 5 reference files out of it. Per the resolved
roadmap option (lift all five), pull each into catalog under
plan-feature/references/ with kendo-tenant specifics swapped to
{{PLACEHOLDER}}-style and stack-specific anecdotes (PLAN-010,
KD-0362's IssueWatcher, KD-0489's scope_type) trimmed to the
generic principle they illustrate.
New reference files:
- decisions-template.md — DECISIONS.md format and rules (KD-XXXX → {{ISSUE_KEY_PREFIX}}-XXXX)
- quality-gates.md — rationale + sycophancy guards for Phase 1.5 + Phase 4d
- anti-patterns.md — lessons-from-pain bullet list (kendo skill names → "the project's testing skills")
- module-shape-lens.md — deep-vs-shallow lens (Laravel-stack exempt list kept as flavor, with adopter-adjustment note)
- plan-template.md — PLAN.md skeleton (KD-XXXX → placeholder, Site Docs Sync table generalized away from kendo paths)
SKILL.md edits:
- Phase 1d: inline lens replaced with cross-ref to module-shape-lens.md
- Phase 1.5: rationale + sycophancy guards moved to quality-gates.md;
the gate table itself stays in SKILL.md (per the lifted note "the
tables themselves live in SKILL.md so they fire reliably")
- Phase 4b: inline DECISIONS.md template → cross-ref to decisions-template.md
- Phase 4c: inline PLAN.md template (~110 lines) → cross-ref to plan-template.md
- Phase 4d: rationale + N/A carve-out + sycophancy guards moved to quality-gates.md;
the gate table stays in SKILL.md
- Anti-patterns to avoid: full bullet list → cross-ref to anti-patterns.md
SKILL.md shrinks 544 → 352 lines.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of PR #4 (Phase 3.5). Lifts the five reference files kendo factored out of
plan-feature/SKILL.mdand collapses the inline equivalents in catalogSKILL.mdto cross-refs.Catalog
plan-feature/SKILL.mdwas 544 lines with all templates inline; this PR brings it down to 352 lines by moving the templates and the gate rationales intoreferences/.New reference files (under
skills/plan-feature/references/)decisions-template.mdKD-XXXX→{{ISSUE_KEY_PREFIX}}-XXXXquality-gates.mdPLAN-010cross-link with a generic anti-patterns referenceanti-patterns.mdfrontend/src/shared/→ "the project's shared layer"; PLAN-010 anecdote → general principlemodule-shape-lens.mdplan-template.mdKD-XXXX→ placeholder; "Site Documentation Sync" table generalized away from kendo pathsSKILL.md changes
quality-gates.md; the gate table itself stays inSKILL.md(per the lifted note: "the tables themselves live in SKILL.md so they fire reliably").quality-gates.md; the gate table stays.Test plan
skills/plan-feature/references/and render correctly on GitHub.SKILL.mdcross-references resolve (relative paths usereferences/<file>.md, not../-style — same skill).PLAN-010,KD-0362,KD-0489) in any of the lifted files.SKILL.mdline count is meaningfully smaller (target: ~350, was 544).Note on stacking
This PR's base is
lift-issue-creation-expansion(PR #4). After PR #4 merges, this PR's base will auto-rebase tomain. Both can land in either order, but reviewing PR #4 first reads more naturally — PR #4 establishes the placeholder convention this PR uses.🤖 Generated with Claude Code