Repository navigation
extract the result response before the callback is issued. - #2133
Conversation
backport of #2132 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
|
@iuhilnehc-ynos requesting review on this. since i borrowed your code, let me assign as co-author. |
|
I'm really not sure if we should backport this one to humble or not. It definitely changes behavior, in that a lock that was held across the callback before no longer is. At the very least, we should do some additional testing in Rolling/Iron before we roll this change out to Humble. |
|
behavior change is actually correct. only thing that i can think of is the following critical case.
I think get system lock during user callback is unnecessary, and we should avoid that situation. there are some places that we do avoid this situation because that is easy to make dead lock. in this particular case, i do not see any reason to keep this mutex lock... maybe i might be missing though 💦
I am not sure if we can add more test for this critical section, but i understand your concern. at least, we can wait for a couple weeks to see #2132 could cause any issue? and then we can come back on this to see if we can backport this or not? How does that sound to you? i mean, i am not pushing this backport fix asap since it is already there, but it would be nicer to avoid this deadlock eventually. |
|
btw, this PR can be backport to foxy. (see #2132 (comment)) |
|
@Mergifyio backport foxy |
✅ Backports have been createdDetails
|
|
Ah, i just found that i did not run the CI against this PR. I will revert this and resubmit the PR again. |
…… (backport #2152) (#2153) * Revert "Revert "extract the result response before the callback is issued. (#2133)" (#2148)" (#2152) This reverts commit 19a666f. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit b2b7bde) * address cpplint error. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
humble backport of #2132