Skip to content

Revert "Revert "extract the result response before the callback is is… - #2152

Merged
fujitatomoya merged 1 commit into
humblefrom
fujitatomoya/revert-pull-2148
Apr 3, 2023
Merged

fujitatomoya merged 1 commit into
humblefrom
fujitatomoya/revert-pull-2148

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

…sued. (#2133)" (#2148)"

This reverts commit 19a666f.

…sued. (#2133)" (#2148)"

This reverts commit 19a666f.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya

fujitatomoya commented Mar 31, 2023 •

Copy link
Copy Markdown
Collaborator Author
  • Linux-aarch64 Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

https://ci.ros2.org/job/ci_linux-aarch64/12918/console hmmm, i am not sure why this is failing to complete, tests look good.

@fujitatomoya
fujitatomoya merged commit b2b7bde into humble Apr 3, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fujitatomoya/revert-pull-2148 branch April 3, 2023 01:03
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

@Mergifyio backport foxy

@mergify

mergify Bot commented Apr 3, 2023 •

Copy link
Copy Markdown
Contributor

backport foxy

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 3, 2023
…sued. (#2133)" (#2148)" (#2152)

This reverts commit 19a666f.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit b2b7bde)
fujitatomoya pushed a commit that referenced this pull request Apr 4, 2023
…… (backport #2152) (#2153)

* Revert "Revert "extract the result response before the callback is issued. (#2133)" (#2148)" (#2152)

This reverts commit 19a666f.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit b2b7bde)

* address cpplint error.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants