Skip to content

Revert "Revert "extract the result response before the callback is is… (backport #2152) - #2153

Merged
fujitatomoya merged 2 commits into
foxyfrom
mergify/bp/foxy/pr-2152
Apr 4, 2023
Merged

fujitatomoya merged 2 commits into
foxyfrom
mergify/bp/foxy/pr-2152

Conversation

@mergify

@mergify mergify Bot commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

This is an automatic backport of pull request #2152 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…sued. (#2133)" (#2148)" (#2152)

This reverts commit 19a666f.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit b2b7bde)
@fujitatomoya

Copy link
Copy Markdown
Collaborator

@iuhilnehc-ynos can you review on this? and if looks good to you, could you also start CI?

@iuhilnehc-ynos

Copy link
Copy Markdown
Collaborator

can you review on this? and if looks good to you, could you also start CI?

Yes, it's my pleasure. Could you address the cpplint issue? @fujitatomoya

09:21:31 8: /tmp/ws/src/rclcpp/rclcpp_action/src/client.cpp:325:  Add #include <utility> for move  [build/include_what_you_use] [4]
09:21:31 8: Done processing /tmp/ws/src/rclcpp/rclcpp_action/src/client.cpp

After that, I'll trigger the CI.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya

Copy link
Copy Markdown
Collaborator

@iuhilnehc-ynos yeah, that only came up with foxy, 2dffd94 addressed cpplint error.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator

https://ci.ros2.org/job/ci_windows/19077/ are unrelated warnings, i will go ahead to merge this.

@fujitatomoya
fujitatomoya merged commit cb226ba into foxy Apr 4, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the mergify/bp/foxy/pr-2152 branch April 4, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants