Skip to content

extract the result response before the callback is issued. - #2132

Merged
fujitatomoya merged 1 commit into
rollingfrom
fujitatomoya/bugfix-rclcpp-issues-2130
Mar 21, 2023
Merged

fujitatomoya merged 1 commit into
rollingfrom
fujitatomoya/bugfix-rclcpp-issues-2130

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

address #2130

@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

@iuhilnehc-ynos can you take a look?

CC: @eschembor-irobot

Comment thread rclcpp_action/src/client.cpp Resolved

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

Comment thread rclcpp_action/src/client.cpp Resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
fujitatomoya force-pushed the fujitatomoya/bugfix-rclcpp-issues-2130 branch from 62c6bae to 41de3ac Compare March 20, 2023 20:31
@fujitatomoya

fujitatomoya commented Mar 20, 2023 •

Copy link
Copy Markdown
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya pushed a commit that referenced this pull request Mar 20, 2023
  backport of #2132

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chen Lihui <lihui.chen@sony.com>
@fujitatomoya

Copy link
Copy Markdown
Collaborator Author

Humble backport is #2133

@fujitatomoya
fujitatomoya merged commit bff5992 into rolling Mar 21, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fujitatomoya/bugfix-rclcpp-issues-2130 branch March 21, 2023 21:11
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Mar 24, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Mar 24, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya pushed a commit that referenced this pull request Mar 30, 2023
backport of #2132

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chen Lihui <lihui.chen@sony.com>
mergify Bot pushed a commit that referenced this pull request Mar 30, 2023
backport of #2132

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit c8ac675)
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request May 3, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants