Repository navigation
[django-filter] Add type stubs - #14540
Merged
Merged
Conversation
This was referenced Aug 6, 2025
This comment has been minimized.
This comment has been minimized.
huynguyengl99
force-pushed
the
feat/django-filters
branch
from
August 6, 2025 12:46
d456d8e to
2fd3c93
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This was referenced Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive type stubs for the django-filter package! 🎉
Hey @carltongibson - would love your thoughts on this as the django-filter maintainer! Hope the type annotations look good from your perspective. 🙌
@AlexWaygood @srittau (and anyone else who'd like to chime in!) - would really appreciate a review of the typeshed patterns and overall structure when you get a chance!
Thanks in advance for taking a look! 😊
Closes #14539