[intgr]

This is all I found that could be improved in #14540. FYI @huynguyengl99

• Accept StrOrPromise for field labels -- allow Django lazy translated strings.
• Added __init__ params that are inherited from parent classes. Reduced usage of loosely typed *args, **kwargs.
• Removed __init__ method type hints from classes whose parameters are same as parent class -- to avoid duplicating them.
• Added missing re-exports to django_filters/rest_framework/__init__.pyi -- the imports in this file are clearly meant as re-export

[donbarbos]

Just a quick note — it’s generally a good practice to add a comment for each use of Any. If you’re unsure whether it should be Any, it might be better to use Incomplete instead.
It’s also important to ensure that the stubtests are passing. And regarding __all__ in type stubs - it should simply reflect the real __all__ in the source code, and it’s worth including it in the stubs if it exists in the source.

[srittau]

LGTM, but one question below.

[intgr]

Thanks, I'll find the time some day to fix CI errors and resolve review comments.

__all__ in type stubs - it should simply reflect the real __all__ in the source code

👍 I will convert them to import X as X imports.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[intgr]

Tests fixed -- restored the _ChoicesInput I copied from django-stubs (and other aliases referenced by _ChoicesInput)