Skip to content

Proposal: absorb django-filter-stubs into typeshed #10918

Closed

Description

@intgr

The django-filter-stubs project has has signalled that they want to be merged into typeshed, project author @DavisRayM agreeing with it: DavisRayM/django-filter-stubs#13

I'm interested in implementing this.

I propose we do this in a way that preserves original commits and authorship information. I can do some git magic to "transplant" upstream commits to this repo, in the correct directory structure, but skipping changes/commits that don't touch .pyi files. And then you can merge that without squashing.

But if you want to squash merge and aren't interested in preserving history, then let me know and I won't bother with that.

Activity

  1. AlexWaygood commented on Oct 19, 2023

    @AlexWaygood
    Member

    Preserving history sounds like a good idea to me, if it's possible.

    Merge commits aren't enabled for this repository (the only two enabled ways of merging are "squash and merge" and "rebase and merge"), but I think repo admins might be able to override that? (I'm not a repo admin, so can't say for sure.)

  2. srittau commented on Oct 19, 2023

    @srittau
    Collaborator

    We can enable merge commits when needed. (Sidenote: I just deleted a webhook that was still pointing to travis-ci, but not surprisingly failing.)

  3. linked a pull request that will close this issue[django-filter] Add type stubs #14540on Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions