Skip to content

Release v5 - #1141

Merged
kjetilk merged 433 commits into
masterfrom
release/v5.0.0
Mar 18, 2019
Merged

kjetilk merged 433 commits into
masterfrom
release/v5.0.0

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Mar 15, 2019 •

Copy link
Copy Markdown
Member

To do

Preparation

Manual testing

  • run tests locally
  • run server locally
  • create an account
  • click around in the data browser
  • edit some things in the data browser
  • add a trusted app
  • use some third-party apps which we did not add as trusted
  • use some third-party apps which we added as trusted for 'Read'
  • use some third-party apps which we added as trusted for 'Read' and 'Write'
  • test https://github.com/Inrupt-inc/generator-solid-react

Documentation

  • changelog, release notes
  • merge this PR
  • git tag v5.0.0 and 🍾

For follow-up:

See #1145

megoth and others added 30 commits November 27, 2018 14:19
Trying to reuse methods from invalidUsernames command
Will improve on it to make it easier to read and some functionality more reusable
And by that hopefully more maintainable
And by that hopefully more maintainable
And by that hopefully more maintainable
And by that hopefully more maintainable
Update index.html based on whether meta-tag is set or not
Fix crash when running solid init
But no actual implementation in patch handler yet
@michielbdejong

michielbdejong commented Mar 15, 2019 •

Copy link
Copy Markdown
Member Author

Issue found during manual testing: https://localhost:8443/common/js/mashlib.min.js will be cached by the browser so people will not see the A-pane (even Shift-Ctrl-R in FF, which I thought was supposed to punch http cache for all resources?) -> i think that last part wasn't true, I was just trying it while the server was stopped. Seeing 'registering pane: trustedApplications' in the console now, but still no A-pane somehow.

@michielbdejong
michielbdejong requested a review from megoth March 18, 2019 12:22

@kjetilk kjetilk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, we are there!

@kjetilk
kjetilk merged commit 19d1bf0 into master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.