Skip to content

Redo #1118 - #1140

Merged
kjetilk merged 1 commit into
nodeSolidServer:release/v5.0.0from
michielbdejong:redo-1118
Mar 15, 2019
Merged

kjetilk merged 1 commit into
nodeSolidServer:release/v5.0.0from
michielbdejong:redo-1118

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Mar 12, 2019 •

Copy link
Copy Markdown
Member

@kjetilk I think this is the changeset you were expecting to see in #1137 right?
What I did was:

git checkout origin/fix/new-branch-faulty-403
git reset origin/release/v5.0.0
git add .
git branch redo-1118
git checkout redo-1118
git commit -am"Redo #1118"

All tests are passing now when I ran them locally.

@michielbdejong
michielbdejong requested a review from kjetilk March 12, 2019 22:26
@kjetilk
kjetilk requested review from RubenVerborgh, dmitrizagidulin and megoth and removed request for kjetilk March 13, 2019 10:49
@kjetilk

kjetilk commented Mar 13, 2019

Copy link
Copy Markdown
Member

Yes, thanks a lot! I would have preferred if all the commits were visible, but I think this is something we can re-review. Please have a go at it!

@michielbdejong michielbdejong mentioned this pull request Mar 15, 2019
24 of 26 tasks

@kjetilk kjetilk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been reviewed in earlier PRs

@kjetilk
kjetilk merged commit 0339003 into nodeSolidServer:release/v5.0.0 Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants