Repository navigation
Redo #1118 - #1140
Merged
Merged
Redo #1118#1140
Conversation
kjetilk
requested review from
RubenVerborgh,
dmitrizagidulin and
megoth
and removed request for
kjetilk
March 13, 2019 10:49
Member
|
Yes, thanks a lot! I would have preferred if all the commits were visible, but I think this is something we can re-review. Please have a go at it! |
kjetilk
approved these changes
Mar 15, 2019
kjetilk
left a comment
Member
There was a problem hiding this comment.
Has been reviewed in earlier PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kjetilk I think this is the changeset you were expecting to see in #1137 right?
What I did was:
All tests are passing now when I ran them locally.