Skip to content

Returns 403 instead of 401 for certain requests #1117

Closed

Description

@megoth

An error that Jairo in Janeiro Digital figured out what was going wrong.

## Please describe what you did in reproducible steps

Logging in with a v5 server using the release/profile-branch of generator-solid-react and trying to edit profile fields.

How did it work with 4.x series servers?

It returned 401, which made solid-auth-client make another request with credentials.

What happened when you tried the same with the 5.0.0 beta?

The server returns 403 on all PATCH-requests. This stops solid-auth-client from sending another request.

Activity

  1. self-assigned this
    on Feb 26, 2019
  2. kjetilk commented on Mar 9, 2019

    @kjetilk
    Member

    There was a test failure when I merged #1118 into the v5 branch, which made me take another look at the tests. There are two failing tests now that I think should work, one is different from previous branch. I have branched it out in fix/new-branch-faulty-403 as I had to revert the merge from #1118.

  3. reopened this on Mar 9, 2019
  4. kjetilk commented on Mar 14, 2019

    @kjetilk
    Member

    Now the fix is in #1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

blockerbugregressionThings that used to work in earlier releases

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions