Repository navigation
[do not merge] Enable trusted apps in dependencies - #1138
Closed
michielbdejong wants to merge 5 commits into
Closed
michielbdejong wants to merge 5 commits into
michielbdejong wants to merge 5 commits into
Conversation
Member
Author
|
There's something funny about how @solid/acl-check is installed, so to try it out: npm install
npm link ../acl-check # have my fix-feature-trusted-app branch here
npm testI will study #1122 some more so I can understand how to merge it without getting loads of failing tests. |
Member
Author
|
Also: #1118 was merged and then reverted, so it should be included again here. |
michielbdejong
force-pushed
the
trusted-apps
branch
from
March 13, 2019 15:21
4be88d2 to
54a20bb
Compare
Member
Author
|
Current status: the test for trusted app is still failing, it's not working correctly yet:
Will continue looking into that tomorrow! |
Member
Author
|
Current status:
|
This was referenced Mar 15, 2019
Merged
michielbdejong
force-pushed
the
trusted-apps
branch
2 times, most recently
from
March 15, 2019 12:21
c551439 to
c978779
Compare
adopt acl-check nodeSolidServer#19 fetch the aclDoc before trying to read from it fix profile fetcher lint fix acl file fetch arg new behavior s mid
use acl-check with trusted-app functionality include nodeSolidServer/acl-check#19 use mashlib with trusted-apps pane npm install temporarily allow git dependencies hard-link acl-check for testing temporarily hardlinking @solid/acl-check fix previous commit also look at default owners of container for finding trusted apps old behavior acl-cche s s test restoore
michielbdejong
force-pushed
the
trusted-apps
branch
from
March 15, 2019 12:23
c978779 to
37c461b
Compare
Member
Author
|
Travis green! \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch tries to envision what NSS 5.0 will look like, by putting together the last unmerged pieces of the puzzle:
Once all these PRs have been merged, we can delete this branch again.