Skip to content

[do not merge] Enable trusted apps in dependencies - #1138

Closed
michielbdejong wants to merge 5 commits into
nodeSolidServer:release/v5.0.0from
michielbdejong:trusted-apps
Closed

michielbdejong wants to merge 5 commits into
nodeSolidServer:release/v5.0.0from
michielbdejong:trusted-apps

Conversation

@michielbdejong

Copy link
Copy Markdown
Member

This branch tries to envision what NSS 5.0 will look like, by putting together the last unmerged pieces of the puzzle:

Once all these PRs have been merged, we can delete this branch again.

@michielbdejong

Copy link
Copy Markdown
Member Author

There's something funny about how @solid/acl-check is installed, so to try it out:

npm install
npm link ../acl-check # have my fix-feature-trusted-app branch here
npm  test

I will study #1122 some more so I can understand how to merge it without getting loads of failing tests.

@michielbdejong

Copy link
Copy Markdown
Member Author

Also: #1118 was merged and then reverted, so it should be included again here.

@michielbdejong

Copy link
Copy Markdown
Member Author

Current status: the test for trusted app is still failing, it's not working correctly yet:

  • it now fetches the aclDoc before trying to read from it, which is a step in the right direction
  • it is determing the doc owner correctly, but not fetching the owner's profile, so that's why that test still fails.

Will continue looking into that tomorrow!

@michielbdejong

Copy link
Copy Markdown
Member Author

Current status:

@michielbdejong
michielbdejong force-pushed the trusted-apps branch 2 times, most recently from c551439 to c978779 Compare March 15, 2019 12:21
adopt acl-check nodeSolidServer#19

fetch the aclDoc before trying to read from it

fix profile fetcher

lint

fix acl file fetch arg

new behavior

s mid
use acl-check with trusted-app functionality

include nodeSolidServer/acl-check#19

use mashlib with trusted-apps pane

npm install

temporarily allow git dependencies

hard-link acl-check for testing

temporarily hardlinking @solid/acl-check

fix previous commit

also look at default owners of container for finding trusted apps

old behavior

acl-cche s

s test restoore
@michielbdejong

Copy link
Copy Markdown
Member Author

Travis green! \o/
Closing this now in favor of #1144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants