Repository navigation
Conversation
Closes #1106.
We had some faulty handling where we returned 403 even if the user wasn't authenticated. (This fixes #1117.) 1. I discovered some redundant tests in test/integration/authentication-oidc-test.js, and moved some tests into groups for better overview. This makes for a lot of changes, but I think it's worth it. 2. I duplicated authentication-oidc-test into authentication-oidc-with-strict-origins-turned-off-test to make sure we handle those permutations correctly as well. This required a lot of setup, which are all of the new files in this commit. 3. I tried to consolidate the use of getTrustedOrigins in create-app.js, which made a test obsolete
My previous explanation was wrong
This reverts commit 90dcfe6.
This reverts commit 01d2a35.
This branch is dependent on https://github.com/solid/acl-check/tree/feature/trusted-app and should be merged after #1118. This should fix #1121
Member
|
I'll have a look at the merge conflicts tomorrow. |
michielbdejong
pushed a commit
to michielbdejong/node-solid-server
that referenced
this pull request
Mar 13, 2019
Member
|
Continued in #1138 |
michielbdejong
pushed a commit
to michielbdejong/node-solid-server
that referenced
this pull request
Mar 15, 2019
michielbdejong
added a commit
to michielbdejong/node-solid-server
that referenced
this pull request
Mar 15, 2019
adopt acl-check nodeSolidServer#19 fetch the aclDoc before trying to read from it fix profile fetcher lint fix acl file fetch arg new behavior s mid
michielbdejong
added a commit
that referenced
this pull request
Mar 15, 2019
kjetilk
added a commit
that referenced
this pull request
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is dependent on https://github.com/solid/acl-check/tree/feature/trusted-app and should be merged after #1118.
This should fix #1121.
I've tried to rebase it on
release/v5.0.0, but it keeps being stuck onfix/faulty-403. I don't know how to fix this, but this PR should be merged after #1118 anyway.