Repository navigation
An attempt at a new pane - trustedApplications - #59
Merged
Merged
Conversation
Allows you to manage web applications by granting (or removing) their origin access. Should fix #58.
michielbdejong
approved these changes
Mar 12, 2019
michielbdejong
left a comment
michielbdejong
left a comment
Contributor
There was a problem hiding this comment.
I tried it out and it seemed to work correctly.
We would need this merged before Friday ideally, because it's a dependency of the NSS 5.0 release)
Contributor
|
If you tried it out and it works then that's good for me. A new pane is new functionality which is very unlikely to break other things, so in general should be encouraged even if they may be imperfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to manage web applications by granting (or removing) their origin access.
Should fix #58.
Implementations for acl-check and node-solid-server are at nodeSolidServer/acl-check#18 and nodeSolidServer/node-solid-server#1122 respectively.