Skip to content

Simpler Runs and Results with Restart; sync without gaps; credential show/hide - #489

Merged
wmobley merged 10 commits into
developfrom
fix/sync-runs-credentials
Nov 20, 2026
Merged

wmobley merged 10 commits into
developfrom
fix/sync-runs-credentials

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Combines #486, #487 and #488 with the Runs and Results redesign, so they build and deploy together.

1. Runs and Results steps, simplified (new)

Reported on dev: the two steps were "confusing with too much going on".

  • Collapsible cards: one animated card per model (Radix Accordion; reduced motion respected). A card that needs attention opens by default; completed cards start closed when there are several models.
  • Runs, single run: status, duration, one next-step sentence, the step strip once (the duplicate step list is gone; task ids sit under "Technical details"), Log and Files, and a collapsed "Settings used". A paused run's edit controls come first. Counters, the run table and the pager appear only for several runs.
  • Restart for a failed or cancelled run:
    • It is shown only when all of the model's runs have finished.
    • Multi-run models get one "Restart all N runs" button with a confirmation step.
    • It carries the earlier maximum run time and queue (from model_result) and pre-selects the earlier publishing choice.
    • One in-flight guard is shared by Runs and Results.
  • Results:
    • Each output is its own block with Download and Copy location.
    • Previews: Markdown rendered by a bounded MarkdownLite, CSV first rows (capped columns and cells), JSON pretty-printed (with size and depth limits).
    • Previews read at most 200 KB via a stream that is cancelled at the cap. A report opens by itself only when it is known to be at most 100 KB.
    • Web (http/https) outputs are never fetched, only downloaded.
    • "How this was made" is collapsed. A paused run links to Runs; a failed run shows Restart.
  • EM (unifiedExecutionService.ts): every adapter-backed plan (pre-model steps, post-model, flow) gets a random nonce inside its signed plan_id. A re-plan after a failure therefore creates a new run instead of returning the failed record. The same plan submitted twice still returns one run. unifiedExecutionRestart.test.ts covers each plan kind.

2. Sync replaces a piece's contracts in the same transaction as its upsert (#486)

This fixes the transient FLOW_WIRE_TARGET / FLOW_WIRE_SOURCE / FLOW_OUTPUT refusals that happened while a catalog sync was running.

3. Run tables show only the settings that differ between runs (#487)

This removes the nested scroll bars in each card.

4. Credentials: show a typed value on request; values saved trimmed (#488)

Reviews

QA and security reviews ran on the redesign, and every finding is fixed:

  • Restart works for every plan kind.
  • Publishing, run time and queue are carried over.
  • No Restart while sibling runs are active.
  • Previews are bounded: no quadratic regex, no auto-fetch of web URLs, stream-and-cancel at the cap.
  • The EM files route was confirmed to restrict paths to the run's own outputs.

Checks

  • ui-react: 169 files / 1760 tests pass; tsc -b and prettier are clean; eslint shows 0 errors.
  • mint-ensemble-manager: 592 tests pass; the same 8 suites that already failed to run locally still fail.
  • svo-adapter-service: 1524 passed; the 4 known local test_demo_api failures (git-ignored .env) remain.
  • Not yet checked in a browser on dev.

Known limits

  • The earlier publish parameter values cannot be recovered, so the runner re-checks them.
  • A restart of a multi-run model sends all its runs again (the confirmation says so).

🤖 Generated with Claude Code

The catalog sync deleted the contracts of every piece first, then upserted the
pieces one request at a time. For the ~30 s that took, a flow check found pieces
with no inputs or outputs and refused runs with FLOW_WIRE_TARGET, FLOW_WIRE_SOURCE
and FLOW_OUTPUT. Each piece's delete and upsert are now one mutation, which
Hasura runs as one transaction.
The Runs step table had one column per adjustable parameter, so flows with
many settings produced wide tables with horizontal and vertical scroll bars
nested inside the step pane. Parameters that differ between the listed runs
keep a column; the rest are summarised once above the table as 'Same for
every run'. The table no longer has its own vertical scroll box.
A pasted key with a space at either end reached the model server as a key
that does not start with sk-, and was refused with a 401 though it looked
right. The Saved credentials form now has a show/hide button for each typed
value and warns when a value starts or ends with a space or a quote mark.
The adapter stores every field with spaces at either end removed, and the
form trims too. Stored values are still never read back.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 10:34pm UTC

A plan for pre-model adapter steps encoded only the thread, the model and the
saved adapter plan ids, so planning the same thread again gave the same plan
id. Submitting it returned the earlier run, which meant a failed run could
never be started again. Add a short nonce to such plans, as flow and
post-model plans already differ on every planning. Submitting one plan twice
still returns the one run.
Runs: one collapsible card per model (status, duration, one next-step
sentence). A flow's steps are drawn once, its task ids sit under a collapsed
Technical details, and a paused run puts its edit controls first. A single run
drops the counters, run configuration box, pager and table for Log, Files and a
collapsed Settings used; several runs keep compact counters, the table trimmed
to what differs, and a pager only past one page. A failed or cancelled run
shows its reason and a Restart button (also on each failed table row) that
sends the model again and is disabled while the send is in flight.

Results: one collapsible card per model with a single Refresh. Each output of a
single run is its own block with type, Download, Copy location and an inline
preview (Markdown report, first CSV rows, indented JSON), read only when open
and capped at 200 KB, with a quiet fallback. How this was made is collapsed. A
run that has not finished says so, with a link to Runs or a Restart. Several
runs keep a trimmed results table.

Update the facilitator guide pages to match.
…kind

A plan id is the encoded plan, and submitting an id that already has a record
returns that record. Pre-model steps, post-model plans and flow plans now all
carry a nonce, so planning again after a failed run is a new run even if the
adapter returns the same plan id, while submitting one plan twice still returns
one run. Tests plan, fail, re-plan and submit for each kind (pre-model, post-
model, flow, plain job) with an adapter that repeats its ids, and check the
plan id size limit with the nonce.
Restart: one control shared by the Runs and Results steps. It carries the
earlier run's maximum time and queue (or shows the default to change), pre-
selects the catalogs the earlier plan published to, is offered only once every
run of the model is over, asks to confirm for a model run several times
(restart all N runs, successes included), and is disabled while a send of that
model is in flight in either step. The per-row button is gone.

Previews: only Tapis files are previewed, never a web address. The body is read
as a stream and cancelled at 200 KB; a Markdown report opens by itself only when
the listing says it is under 100 KB. Markdown input is bounded (line length,
line count, bounded patterns) with a notice, links show their host, CSV rows and
cells are capped, JSON is indented only below a size and depth limit, and a cut
off JSON or CSV is described as cut off.
@wmobley wmobley changed the title Sync without gaps, run tables without nested scroll, credential show/hide and trimming Simpler Runs and Results with Restart; sync without gaps; credential show/hide Nov 20, 2026
@wmobley
wmobley merged commit eb670fb into develop Nov 20, 2026
40 checks passed

This branch was successfully deployed

1 active deployment
Preview — af333f80 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant