Repository navigation
Conversation
The catalog sync deleted the contracts of every piece first, then upserted the pieces one request at a time. For the ~30 s that took, a flow check found pieces with no inputs or outputs and refused runs with FLOW_WIRE_TARGET, FLOW_WIRE_SOURCE and FLOW_OUTPUT. Each piece's delete and upsert are now one mutation, which Hasura runs as one transaction.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Combined into #489 so all three build and deploy together. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen on dev: runs were briefly refused with "This flow does not fit its pieces or its data" (
FLOW_WIRE_TARGET,FLOW_WIRE_SOURCE,FLOW_OUTPUTon every step), then went through a little later.Cause:
POST /admin/sync-from-mintdeleted the contracts of every piece up front, then upserted the pieces one request at a time (about 250 requests, ~30 s on dev). Any flow checked in that window saw pieces with no inputs or outputs.Fix: each piece's contract delete and upsert are now root fields of one mutation (
ReplaceMintSyncSpec/ReplaceMintETLSpec), which Hasura runs in order inside one transaction, so a piece is never visible without its contracts. Rows synced without contracts keep theirs, as before. The single-piece path (sync_one_etl_process) uses the same mutation. The demo store handles the new operations.Tests: adapter 1522 passed; 4 pre-existing local
test_demo_apifailures (git-ignored.env).test_etl_sync_roundtripnow checks that one request carries both the delete and the upsert, delete first, and that no separate bulk delete runs.🤖 Generated with Claude Code