Skip to content

Results: preview kind from the file location, not the label - #490

Merged
wmobley merged 1 commit into
developfrom
fix/preview-kind-from-location
Nov 20, 2026
Merged

wmobley merged 1 commit into
developfrom
fix/preview-kind-from-location

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Found checking #489 on dev: no output on the Results step offered a preview, and the Sensemaking report did not open by itself, though the file listing returned kind: "file" with sizes (e.g. summary.md, 1,433 bytes).

Cause: OutputBlock decided the preview kind with previewKind(name), where name is the result's name. Runs name results by their label ("Sensemaking report"), so no extension was found and nothing was previewable. The unit tests named results report.md, so they passed.

Fix:

  • outputPreviewKind(url, name, format) checks the file's location first, then the name, then the declared format (md / Markdown / csv / json).
  • The type tag falls back to the location's extension too.
  • The test fixtures now name results by label, as runs do; the existing preview tests fail without the fix.
  • A unit test was added for outputPreviewKind.

Checks: ui-react 169 files / 1761 tests pass; tsc -b, prettier and eslint clean.

🤖 Generated with Claude Code

…abel

Runs name a result by its label ("Sensemaking report"), so reading the
preview kind and the type tag from the name found no extension and no
output could be previewed on dev. The kind now comes from the file's
location, then the name, then the declared format; the type tag falls
back to the location too. The test fixtures name results by label, as
runs do.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 11:27pm UTC

@wmobley
wmobley merged commit e85759d into develop Nov 20, 2026
42 checks passed

This branch was successfully deployed

1 active deployment
Preview — ef359d4b Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant