Repository navigation
Results: preview kind from the file location, not the label - #490
Merged
Merged
Conversation
…abel
Runs name a result by its label ("Sensemaking report"), so reading the
preview kind and the type tag from the name found no extension and no
output could be previewed on dev. The kind now comes from the file's
location, then the name, then the declared format; the type tag falls
back to the location too. The test fixtures name results by label, as
runs do.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found checking #489 on dev: no output on the Results step offered a preview, and the Sensemaking report did not open by itself, though the file listing returned
kind: "file"with sizes (e.g.summary.md, 1,433 bytes).Cause:
OutputBlockdecided the preview kind withpreviewKind(name), wherenameis the result's name. Runs name results by their label ("Sensemaking report"), so no extension was found and nothing was previewable. The unit tests named resultsreport.md, so they passed.Fix:
outputPreviewKind(url, name, format)checks the file's location first, then the name, then the declared format (md/Markdown/csv/json).outputPreviewKind.Checks: ui-react 169 files / 1761 tests pass;
tsc -b, prettier and eslint clean.🤖 Generated with Claude Code