Repository navigation
Conversation
A pasted key with a space at either end reached the model server as a key that does not start with sk-, and was refused with a 401 though it looked right. The Saved credentials form now has a show/hide button for each typed value and warns when a value starts or ends with a space or a quote mark. The adapter stores every field with spaces at either end removed, and the form trims too. Stored values are still never read back.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Combined into #489 so all three build and deploy together. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen on dev: a runner's Narrative run failed at the first embedding call with
401 LiteLLM Virtual Key expected ... expected to start with 'sk-', while the key worked elsewhere. LiteLLM masks the received key assk-…plus its last four characters, so what reached it did not start withsk-. The likely cause is a pasted leading space or quote mark, which DYNAMO accepted and the step sent as is.Saved credentials form (
CredentialsPage.tsx,user-secrets.ts):Adapter (
secrets.py):validate_fieldsreturns the fields with spaces at either end of each value removed, and the store saves what it returns, so a value is trimmed whatever client sent it. Spaces inside a value are kept. A value of only spaces is refused. Quote marks are not changed, since a value may legitimately contain them.Checks: ui-react 162 files pass (1 new page test: show/hide, both warnings, the trimmed save);
tsc -b, prettier and eslint clean on the changed files. Adapter 1524 passed; 4 pre-existing localtest_demo_apifailures. New tests cover trimming and a spaces-only value being refused.For the runner already affected: re-enter the
model_servercredential once this is live (or now, with care), and checkembedding_base_urlis the same Tejas address aschat_base_url.🤖 Generated with Claude Code