Repository navigation
Result resolver feature branch - #21457
Merged
Merged
Conversation
This is branch will serve as a feature branch for all changes related to switching to the remote resolver. This will include - switching from using the testAdapter to parse the return data to now using this new class resultResolver - adding tests for all testAdapters, fixing for server and adding for resultResolver - moving sendCommand to a new file, out of the server, and getting pytest to adopt it - moving the server which send the test IDs to a new file and adopt it for both pytest and unittest - write tests for these two new files.
Created a testIdServer to handle the starting up of the testIdServer for both unittest and pytest. This extracts the method to be in another file and easy to test.
adds test coverage for `testExecutionAdapter.ts` and `pytestExecutionAdapter.ts`.
This PR - moves populateTestTree to utils - adds tests for execution adapters (pytest and unittest) - resultResolver tests - workspaceTestAdapater tests
Eleanor Boyd (eleanorjboyd)
added
debt
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
June 20, 2023 20:01
Author
|
this PR does not actually enable dynamic run results- it only setups up the resultResolver class which allows for dynamic to start happening. The actual PR to have the packages sent by the python server be dynamic will come after. |
Brett Cannon (brettcannon)
removed their request for review
June 20, 2023 23:17
Karthik Nadig (karthiknadig)
approved these changes
Jun 21, 2023
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21394