Skip to content

Execution adapter tests - #21421

Merged
Eleanor Boyd (eleanorjboyd) merged 20 commits into
microsoft:resultResolver-feature-branchfrom
eleanorjboyd:executionAdapter-tests
Jun 13, 2023
Merged

Eleanor Boyd (eleanorjboyd) merged 20 commits into
microsoft:resultResolver-feature-branchfrom
eleanorjboyd:executionAdapter-tests

Conversation

@eleanorjboyd

Copy link
Copy Markdown

adds test coverage for testExecutionAdapter.ts and pytestExecutionAdapter.ts.

@eleanorjboyd Eleanor Boyd (eleanorjboyd) added the debt Code quality issues label Jun 13, 2023
@eleanorjboyd
Eleanor Boyd (eleanorjboyd) changed the base branch from main to resultResolver-feature-branch June 13, 2023 18:27
@eleanorjboyd
Eleanor Boyd (eleanorjboyd) marked this pull request as ready for review June 13, 2023 18:48
@roblourens

Copy link
Copy Markdown
Member

You don't need reviews for PRs that aren't going into main

@eleanorjboyd

Copy link
Copy Markdown
Author

The plan that I had determined with Brett/Karthik was that I would have each PR go through review to be merged into the feature branch so then the final merge from the feature branch to main isn't so time-consuming since all the parts have already been reviewed. (just a way to manage a large PR/ feature area since I'm less experienced)

@roblourens

roblourens commented Jun 13, 2023 •

Copy link
Copy Markdown
Member

So you want an in-depth review? That's fine but it's not what we usually do for PRs in #codereview, especially for feature areas that I'm not familiar with. So if that's what you want you should make that clear or assign a reviewer and remove it from the review channel

@eleanorjboyd

Copy link
Copy Markdown
Author

So you want an in-depth review? That's fine but it's not what we usually do for PRs in #codereview, especially for feature areas that I'm not familiar with. So if that's what you want you should make that clear or assign a reviewer and remove it from the review channel

ok sweet that makes sense- thanks for that extra info on the best place to put these things in the future!

@eleanorjboyd
Eleanor Boyd (eleanorjboyd) merged commit 4d1c196 into microsoft:resultResolver-feature-branch Jun 13, 2023
@eleanorjboyd
Eleanor Boyd (eleanorjboyd) deleted the executionAdapter-tests branch June 13, 2023 23:30
Eleanor Boyd (eleanorjboyd) added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
adds test coverage for `testExecutionAdapter.ts` and
`pytestExecutionAdapter.ts`.
Eleanor Boyd (eleanorjboyd) added a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
adds test coverage for `testExecutionAdapter.ts` and
`pytestExecutionAdapter.ts`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants