Skip to content

Remote resolver - #21332

Merged
Eleanor Boyd (eleanorjboyd) merged 18 commits into
microsoft:resultResolver-feature-branchfrom
eleanorjboyd:remote-resolver
Jun 12, 2023
Merged

Eleanor Boyd (eleanorjboyd) merged 18 commits into
microsoft:resultResolver-feature-branchfrom
eleanorjboyd:remote-resolver

Conversation

@eleanorjboyd

@eleanorjboyd Eleanor Boyd (eleanorjboyd) commented May 30, 2023 •

Copy link
Copy Markdown

This is branch will serve as a feature branch for all changes related to switching to the remote resolver.
This will include

  • switching from using the testAdapter to parse the return data to now using this new class resultResolver
  • adding tests for all testAdapters, fixing for server and adding for resultResolver
  • moving sendCommand to a new file, out of the server, and getting pytest to adopt it
  • moving the server which send the test IDs to a new file and adopt it for both pytest and unittest
  • write tests for these two new files.

@eleanorjboyd

Copy link
Copy Markdown
Author

tests written so far:

  • pytestDiscoveryAdapter
    - discovery should call exec with correct basic args
    - discovery should pull from setting to get pytest args
  • pytestExecutionAdapter
    - pytest execution called with correct args
    - Debug launched correctly for pytest
  • testDiscoveryAdapter (unittest)
    - discovery should call sendCommand with correct basic args

@eleanorjboyd
Eleanor Boyd (eleanorjboyd) merged commit 8cec0fc into microsoft:resultResolver-feature-branch Jun 12, 2023
@eleanorjboyd
Eleanor Boyd (eleanorjboyd) deleted the remote-resolver branch June 12, 2023 18:15
Eleanor Boyd (eleanorjboyd) pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 12, 2023
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
Eleanor Boyd (eleanorjboyd) pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
Eleanor Boyd (eleanorjboyd) pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
Eleanor Boyd (eleanorjboyd) pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
Eleanor Boyd (eleanorjboyd) pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 21, 2023
This is branch will serve as a feature branch for all changes related to
switching to the remote resolver.
This will include
- switching from using the testAdapter to parse the return data to now
using this new class resultResolver
- adding tests for all testAdapters, fixing for server and adding for
resultResolver
- moving sendCommand to a new file, out of the server, and getting
pytest to adopt it
- moving the server which send the test IDs to a new file and adopt it
for both pytest and unittest
- write tests for these two new files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants