Repository navigation
Move testid server - #21400
Merged
Eleanor Boyd (eleanorjboyd) merged 23 commits intoJun 13, 2023
Merged
Move testid server#21400Eleanor Boyd (eleanorjboyd) merged 23 commits into
Eleanor Boyd (eleanorjboyd) merged 23 commits into
Conversation
fixes microsoft#21397. The issue came from the setup of running a script that then runs pytest which is different then pytest discovery which runs pytest as a module. The run script didn't work since the script did not insert the cwd into the path like what is done when running a module. This change inserts the cwd.
is the beginning of this issue: microsoft#21150, in that it will start the process of implementing the setting in the extension
Eleanor Boyd (eleanorjboyd)
added
debt
Eleanor Boyd (eleanorjboyd)
requested review from
Anthony Kim (anthonykim1),
Karthik Nadig (karthiknadig) and
Paula (paulacamargo25)
June 9, 2023 20:53
Author
|
This should be merged after #21332 |
This is branch will serve as a feature branch for all changes related to switching to the remote resolver. This will include - switching from using the testAdapter to parse the return data to now using this new class resultResolver - adding tests for all testAdapters, fixing for server and adding for resultResolver - moving sendCommand to a new file, out of the server, and getting pytest to adopt it - moving the server which send the test IDs to a new file and adopt it for both pytest and unittest - write tests for these two new files.
Eleanor Boyd (eleanorjboyd)
force-pushed
the
move-testid-server
branch
from
June 12, 2023 18:18
9b3260b to
4bd1d0b
Compare
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
June 12, 2023 21:37
roblourens
approved these changes
Jun 12, 2023
roblourens
left a comment
roblourens
left a comment
Member
There was a problem hiding this comment.
Is this supposed to go into main?
Author
we are putting everything in a feature branch before merging into main |
Eleanor Boyd (eleanorjboyd)
merged commit Jun 13, 2023
dc5fa4e
into
microsoft:resultResolver-feature-branch
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jun 21, 2023
Created a testIdServer to handle the starting up of the testIdServer for both unittest and pytest. This extracts the method to be in another file and easy to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a testIdServer to handle the starting up of the testIdServer for both unittest and pytest. This extracts the method to be in another file and easy to test.