Repository navigation
fix pytest run script to add cwd to path - #21399
Merged
Eleanor Boyd (eleanorjboyd) merged 1 commit intoJun 9, 2023
Merged
Eleanor Boyd (eleanorjboyd) merged 1 commit into
Eleanor Boyd (eleanorjboyd) merged 1 commit into
Conversation
Eleanor Boyd (eleanorjboyd)
requested review from
Anthony Kim (anthonykim1),
Karthik Nadig (karthiknadig) and
Paula (paulacamargo25)
June 9, 2023 20:16
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
June 9, 2023 20:16
Karthik Nadig (karthiknadig)
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21397. The issue came from the setup of running a script that then runs pytest which is different then pytest discovery which runs pytest as a module. The run script didn't work since the script did not insert the cwd into the path like what is done when running a module. This change inserts the cwd.