Repository navigation
Fix crash with Object.defineProperty for imported alias (--allowJs) - #35198
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoNov 20, 2019
Conversation
Nathan Shively-Sanders (sandersn)
approved these changes
Nov 20, 2019
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.7 if you can |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 20, 2019
Component commits: 9c0fab9 Fix crash with Object.defineProperty for imported alias (--allowJs) Fixes microsoft#35196
Contributor
|
Hey Nathan Shively-Sanders (@sandersn), I've opened #35240 for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35196
Follows the same approach as #34650 and #34566
Please verify that:
Backlogmilestone (required)masterbranchgulp runtestslocally