Repository navigation
Fix crash in expando assignment to alias - #34566
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoOct 18, 2019
Merged
Conversation
This PR disallows expando assignments Fixes #34493, but disallows the prototype assignment nonetheless.
Member
|
Note: this is a superset of #34553 |
Member
Author
|
Sorry, that was a mistake because I was testing #34553 locally and forgot. I reverted those changes because it's much too confusing otherwise. |
Andrew Branch (andrewbranch)
approved these changes
Oct 18, 2019
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
Is the fact that expandos don't work on alias symbols documented anywhere? I guess people don’t run into this very often.
Member
Author
|
Given that I didn't think of this before, I'd guess not. Our test coverage is heavily biased toward commonjs importing commonjs. |
Nathan Shively-Sanders (sandersn)
deleted the
fix-expando-assignment-to-alias
branch
October 18, 2019 20:31
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disallows expando assignments
Fixes #34493, but disallows the prototype assignment, which never worked.