Repository navigation
Fix crash in assigning function with this ref to alias - #34650
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoOct 22, 2019
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit into
Nathan Shively-Sanders (sandersn) merged 1 commit into
Conversation
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 22, 2019
Member
|
Nice catch, thanks Kārlis Gaņģis (@Knagis)! |
Member
|
Ryan Cavanaugh (@RyanCavanaugh) Daniel Rosenwasser (@DanielRosenwasser) here's another one that should be in 3.7.2. |
Member
|
TypeScript Bot (@typescript-bot) cherry pick this |
Member
|
Argghh TypeScript Bot (@typescript-bot) cherry-pick this And next time reply "I don't know how to cherry pick this" |
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.7 And next time reply "Where should I cherry-pick this to?" |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 22, 2019
Component commits: 6a6f4a6 Fix crash in assigning function with this ref to alias
Contributor
|
Hey Nathan Shively-Sanders (@sandersn), I've opened #34658 for you. |
Nathan Shively-Sanders (sandersn)
pushed a commit
that referenced
this pull request
Oct 22, 2019
Component commits: 6a6f4a6 Fix crash in assigning function with this ref to alias
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34647
Backlogmilestone (required)masterbranchgulp runtestslocally