Repository navigation
--allowJs: Object.defineProperty on imported alias crashes compiler #35196
Description
TypeScript Version: 3.7.2, 3.8.0-dev-20191119, master
Search Terms: bindObjectDefinePrototypeProperty
Code
import A from "./a";
Object.defineProperty(A.prototype, "foo", {
value: 0
});Expected behavior:
Code transpiles without errors.
Actual behavior:
TypeError: Cannot set property 'symbol' of undefined
at addDeclarationToSymbol (node_modules\typescript\lib\tsc.js:23649:25)
at bindObjectDefinePrototypeProperty (node_modules\typescript\lib\tsc.js:25640:17)
at bindWorker (node_modules\typescript\lib\tsc.js:25370:36)
at bind (node_modules\typescript\lib\tsc.js:25179:13)
at bindExpressionStatement (node_modules\typescript\lib\tsc.js:24503:13)
at bindChildrenWorker (node_modules\typescript\lib\tsc.js:24010:21)
at bindChildren (node_modules\typescript\lib\tsc.js:23931:17)
at bind (node_modules\typescript\lib\tsc.js:25185:21)
at node_modules\typescript\lib\tsc.js:23937:68
at bindEach (node_modules\typescript\lib\tsc.js:23953:21)
Activity
Fix crash with Object.defineProperty for imported alias (--allowJs)
Knagis commentedon Nov 19, 2019
Nathan Shively-Sanders (@sandersn) - pinging you since you handled the related issues. The linked PR follows the same approach as the previous two.
Knagis commentedon Nov 19, 2019
Any chance this could also be added to 3.7.3?
Fix crash with Object.defineProperty for imported alias (--allowJs) (#…
sandersn commentedon Nov 20, 2019
It's a simple fix for a crash, so I think it's a good fit for 3.7.3.
Cherry-pick PR microsoft#35198 into release-3.7
Cherry-pick PR #35198 into release-3.7 (#35240)