Repository navigation
fix!: plan commands carry an argv, never a shell string - #6
Merged
Merged
Conversation
PlannedCommand.cmd (a string the host ran through $SHELL -c) becomes PlannedCommand.argv: the program and its arguments, run as given. PluginRequest.command holds only the claimed command words. Implements [[tasks/harmony-2756]]
Implements [[tasks/harmony-2756]]
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the meta fix for fuzz findings fuzz-2026-10-24-01 (shell re-parsing of arguments) and -21 (substring --include/--exclude). Main PR with the full description and verification: gitkb/meta#113 (other PRs: gitkb/loop_lib#14 gitkb/loop_cli#13 gitkb/meta_cli#40 gitkb/meta_git_cli#31 gitkb/meta_mcp#11 gitkb/meta_rust_cli#16 gitkb/meta_project_cli#18 )
PlannedCommand.cmd: String(run by the host with$SHELL -c) becomesPlannedCommand.argv: Vec<String>, spawned directly. Documents thatPluginRequest.commandholds only claimed words and that include/exclude are already applied toprojects.All PRs share branch
fix/run-commands-as-argvand are tested together by gitkb/meta CI.