Repository navigation
fix: pass the command to loop_lib as argv - #13
Merged
Merged
Conversation
Implements [[tasks/harmony-2756]]
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This was referenced Oct 25, 2026
added 3 commits
October 25, 2026 05:00
Clones loop_lib (and the other deps) from this PR's branch when it exists, like meta_cli and meta_git_cli do, so cross-repo changes test together. Implements [[tasks/harmony-2756]]
Implements [[tasks/harmony-2756]]
Implements [[tasks/harmony-2756]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the meta fix for fuzz findings fuzz-2026-10-24-01 (shell re-parsing of arguments) and -21 (substring --include/--exclude). Main PR with the full description and verification: gitkb/meta#113 (other PRs: gitkb/meta_plugin_protocol#6 gitkb/loop_lib#14 gitkb/meta_cli#40 gitkb/meta_git_cli#31 gitkb/meta_mcp#11 gitkb/meta_rust_cli#16 gitkb/meta_project_cli#18 )
Passes the typed argv to
loop_lib::runinstead of joining it with spaces.All PRs share branch
fix/run-commands-as-argvand are tested together by gitkb/meta CI.Also: CI clones loop_lib from a branch with this PR's name when it exists (falling back to the default branch), as meta_cli's CI does, so cross-repo changes build together.