Skip to content
This repository was archived by the owner on Nov 3, 2026. It is now read-only.

fix: pass git arguments through as argv - #31

Merged
gold-silver-copper merged 7 commits into
mainfrom
fix/run-commands-as-argv
Oct 25, 2026
Merged

gold-silver-copper merged 7 commits into
mainfrom
fix/run-commands-as-argv

Conversation

@gold-silver-copper

@gold-silver-copper gold-silver-copper commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Part of the meta fix for fuzz findings fuzz-2026-10-24-01 (shell re-parsing of arguments) and -21 (substring --include/--exclude). Main PR with the full description and verification: gitkb/meta#113 (other PRs: gitkb/meta_plugin_protocol#6 gitkb/loop_lib#14 gitkb/loop_cli#13 gitkb/meta_cli#40 gitkb/meta_mcp#11 gitkb/meta_rust_cli#16 gitkb/meta_project_cli#18 )

Raw pass-through, commit -m and status build argv. worktree exec --include/--exclude use meta_cli's whole-repo selection. snapshot restore refuses --include/--exclude (it restores the whole snapshot).

All PRs share branch fix/run-commands-as-argv and are tested together by gitkb/meta CI.

Also: git update, git snapshot restore and the git worktree ... commands refuse a global --include/--exclude (they find their repos themselves); worktree exec selects by alias via its own flags. --help/-h after -- are arguments. SSH multiplexing keys on argv[1].

gold-silver-copper and others added 2 commits October 25, 2026 04:34
Raw pass-through, commit -m and status build argv, so arguments reach
git as typed. worktree exec --include/--exclude name whole repos.

Implements [[tasks/harmony-2756]]
…ilters

snapshot restore restores every repo in the snapshot, so it now refuses
--include/--exclude instead of ignoring them.

Implements [[tasks/harmony-2756]]
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 489cfc89-5cf6-451a-ba85-b686280afafd
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

t added 5 commits October 25, 2026 05:05
It clones every missing repo the .meta files list, not the selected
ones, so it refuses filters like snapshot restore does.

Implements [[tasks/harmony-2756]]
They find their repos in the set and used to ignore the global filters.
worktree exec selects by alias.

Implements [[tasks/harmony-2756]]
…repos come from

Implements [[tasks/harmony-2756]]
@gold-silver-copper
gold-silver-copper merged commit d4f7f77 into main Oct 25, 2026
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant