Skip to content

docs(adr): add sqlite topic store parity plan - #633

Merged
delete-cloud merged 1 commit into
mainfrom
adr/0073-sqlite-topic-store-parity
Jun 26, 2026
Merged

delete-cloud merged 1 commit into
mainfrom
adr/0073-sqlite-topic-store-parity

Conversation

@delete-cloud

@delete-cloud delete-cloud commented Jun 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add ADR-0073 for SQLite TopicStore parity on the local durable SQLite path
  • add the implementation task packet for the next SQLiteTopicStore parity PR
  • capture reviewed gates for selected TopicStore wiring, fenced SQLite mutations, semantic rebuild authority, Helm defaults, and docs acceptance

Verification

  • git diff --check -- docs/adr/0073-sqlite-topic-store-parity.md .opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md
  • local subagent review, storage/schema/fencing focus: no P1/P2 findings after fixes
  • local subagent review, product/runtime/semantic/Helm focus: no P1/P2 findings after fixes

Implementation code is intentionally out of scope for this PR.

Summary by CodeRabbit

  • New Features

    • Added guidance for a new durable SQLite topic store path, alongside the existing PostgreSQL-backed path.
    • Clarified when the app should select SQLite, PostgreSQL, or no topic store based on runtime configuration.
  • Documentation

    • Added an ADR describing topic-store parity rules, storage behavior, mutation safeguards, and runtime wiring.
    • Included implementation steps, test coverage expectations, and review/stop conditions for the work.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds ADR-0073 describing SQLite TopicStore parity, store-selection rules, SQLite storage guarantees, runtime wiring, and acceptance criteria, plus a task packet that records implementation scope, commands, and review gates.

Changes

SQLite TopicStore parity docs

Layer / File(s) Summary
ADR background and selection rules
coding-agent/docs/adr/0073-sqlite-topic-store-parity.md
Defines the ADR background and the product-layer rules for selecting a durable TopicStore across local SQLite, PostgreSQL, and non-durable modes.
SQLite store guarantees and runtime wiring
coding-agent/docs/adr/0073-sqlite-topic-store-parity.md
Defines SQLite TopicStore schema and mutation guarantees, then threads the selected durable store into runtime creation and semantic maintainer setup.
ADR acceptance criteria and references
coding-agent/docs/adr/0073-sqlite-topic-store-parity.md
Lists rejected alternatives, acceptance criteria, non-goals, and related references for the parity decision.
Implementation packet scope and gates
coding-agent/.opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md
Defines the task packet scope, implementation steps, test commands, and review-stop conditions for the parity work.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hopped through ADR ink and moonlit code,
Found SQLite carrots on the path I strode.
Two topic stores now twinkle in the burrow glow,
With tests as tiny lanterns in a row.
Hop, hop—my whiskers say “let it flow.” 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main change: adding an ADR and task packet for SQLite TopicStore parity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adr/0073-sqlite-topic-store-parity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
coding-agent/.opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md (2)

136-148: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Clarify P1/P2 priority terminology.

The task packet references "P1/P2 review findings" (lines 137, 145) without defining these priority levels. While this may be established project terminology, consider adding a brief parenthetical or reference to where priority levels are defined, especially since this packet may be consumed by engineers unfamiliar with the project's review taxonomy.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@coding-agent/.opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md`
around lines 136 - 148, Clarify the “P1/P2” terminology used in the review gate
and loop policy so readers know what counts as a blocking finding. Update the
task packet text around the “review findings” and “Reviewer reports” steps to
add a brief parenthetical definition or a reference to the project’s priority
taxonomy, keeping the wording consistent with the rest of the packet.

44-84: 🧹 Nitpick | 🔵 Trivial

Add missing semantic_sync.py to the Context file list.

Both semantic_sync.py and semantic_recall.py exist in the codebase as separate, active files. The ADR-0073 correctly references semantic_sync.py, but the task packet's Context section omits it.

Add this file to the "Relevant files" list:

  • coding-agent/src/coding_agent/topics/semantic_sync.py

Both files serve distinct purposes and should be referenced together for accurate implementation context.

``

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@coding-agent/.opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md`
around lines 44 - 84, The Context section is missing the active semantic
synchronization module, so update the task packet’s Relevant files list to
include coding-agent/src/coding_agent/topics/semantic_sync.py alongside
semantic_recall.py. Keep the list aligned with ADR-0073 and the topic-layer
implementation context so both distinct modules are referenced together in the
packet.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@coding-agent/.opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md`:
- Around line 136-148: Clarify the “P1/P2” terminology used in the review gate
and loop policy so readers know what counts as a blocking finding. Update the
task packet text around the “review findings” and “Reviewer reports” steps to
add a brief parenthetical definition or a reference to the project’s priority
taxonomy, keeping the wording consistent with the rest of the packet.
- Around line 44-84: The Context section is missing the active semantic
synchronization module, so update the task packet’s Relevant files list to
include coding-agent/src/coding_agent/topics/semantic_sync.py alongside
semantic_recall.py. Keep the list aligned with ADR-0073 and the topic-layer
implementation context so both distinct modules are referenced together in the
packet.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ddd8a69b-38e6-48a2-92bc-b1329db40e30

📥 Commits

Reviewing files that changed from the base of the PR and between 1d76d8b and 911a7cc.

📒 Files selected for processing (2)
  • coding-agent/.opencode/prompts/tasks/sqlite-topic-store-parity-task-packet.md
  • coding-agent/docs/adr/0073-sqlite-topic-store-parity.md

@delete-cloud
delete-cloud merged commit 55f2f10 into main Jun 26, 2026
2 checks passed
@delete-cloud
delete-cloud deleted the adr/0073-sqlite-topic-store-parity branch June 26, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant