Repository navigation
test(memory): cover sqlite semantic recall path - #636
Conversation
Add a bounded task packet and product-level regression for the local SQLite durable semantic memory path: durable topic creation/finalization, semantic rebuild, and later build_context recall from authoritative topic data. Verification: - uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q - uv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/plugins/test_semantic_memory.py -q - uv run pytest tests/ui/test_session_manager_runtime.py -k 'selected_topic_store or semantic_topic_store or semantic_memory' -q - uv run pytest tests/coding_agent/test_sqlite_local_durable_fencing.py -k 'selected_topic_store or topic_store or semantic' -q - uv run pytest tests/coding_agent/test_semantic_recall.py tests/coding_agent/test_semantic_sync.py tests/coding_agent/test_semantic_tape_index.py -q - uv run ruff check tests/ui/test_session_manager_runtime.py && uv run ruff format --check tests/ui/test_session_manager_runtime.py
|
Warning Review limit reached
More reviews will be available in 53 minutes and 26 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds an end-to-end task packet for durable SQLite semantic-memory recall and a runtime test that creates a durable topic, rebuilds semantic context, and checks later recall renders the durable summary instead of backend sentinel text. ChangesSQLite semantic recall regression
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@coding-agent/tests/ui/test_session_manager_runtime.py`:
- Line 301: The negative check for "stale backend value" in the session manager
runtime test is vacuous because that text is never inserted anywhere, so it
cannot validate rendering behavior. Update the test around the rendered
assertion in test_session_manager_runtime to either remove this unused check or
first upsert a distinct stale value through the same backend document path
before recall so the assertion meaningfully verifies that the output is not
stale or mutated. Keep the existing backend_sentinel coverage and make the new
assertion target a value actually introduced by the test setup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ee31eb62-0b1f-4922-bd2e-bd62d11bd897
📒 Files selected for processing (2)
coding-agent/.opencode/prompts/tasks/tape-memory-sqlite-recall-e2e-task-packet.mdcoding-agent/tests/ui/test_session_manager_runtime.py
Keep the meaningful backend_sentinel check and drop the unused stale backend string assertion flagged by review. Verification: - uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q - uv run ruff check tests/ui/test_session_manager_runtime.py - git diff --check
Summary
Tests
uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -quv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/plugins/test_semantic_memory.py -quv run pytest tests/ui/test_session_manager_runtime.py -k "selected_topic_store or semantic_topic_store or semantic_memory" -quv run pytest tests/coding_agent/test_sqlite_local_durable_fencing.py -k "selected_topic_store or topic_store or semantic" -quv run pytest tests/coding_agent/test_semantic_recall.py tests/coding_agent/test_semantic_sync.py tests/coding_agent/test_semantic_tape_index.py -quv run ruff check tests/ui/test_session_manager_runtime.py && uv run ruff format --check tests/ui/test_session_manager_runtime.pyReview
Summary by CodeRabbit
Bug Fixes
Tests