Repository navigation
test(memory): cover sqlite semantic recall path - #637
Merged
Merged
Conversation
Add a bounded task packet and product-level regression for the local SQLite durable semantic memory path: durable topic creation/finalization, semantic rebuild, and later build_context recall from authoritative topic data. Verification: - uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q - uv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/plugins/test_semantic_memory.py -q - uv run pytest tests/ui/test_session_manager_runtime.py -k 'selected_topic_store or semantic_topic_store or semantic_memory' -q - uv run pytest tests/coding_agent/test_sqlite_local_durable_fencing.py -k 'selected_topic_store or topic_store or semantic' -q - uv run pytest tests/coding_agent/test_semantic_recall.py tests/coding_agent/test_semantic_sync.py tests/coding_agent/test_semantic_tape_index.py -q - uv run ruff check tests/ui/test_session_manager_runtime.py && uv run ruff format --check tests/ui/test_session_manager_runtime.py
Keep the meaningful backend_sentinel check and drop the unused stale backend string assertion flagged by review. Verification: - uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q - uv run ruff check tests/ui/test_session_manager_runtime.py - git diff --check
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates the tape-memory SQLite recall task packet’s loop policy so reviewer findings are limited to P1/P2 instead of P0/P1, while the engineer fix-and-rerun instruction stays the same. ChangesLoop policy prompt update
Estimated review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…recall-e2e # Conflicts: # coding-agent/.opencode/prompts/tasks/tape-memory-sqlite-recall-e2e-task-packet.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -quv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/plugins/test_semantic_memory.py -quv run pytest tests/ui/test_session_manager_runtime.py -k "selected_topic_store or semantic_topic_store or semantic_memory" -quv run pytest tests/coding_agent/test_sqlite_local_durable_fencing.py -k "selected_topic_store or topic_store or semantic" -quv run pytest tests/coding_agent/test_semantic_recall.py tests/coding_agent/test_semantic_sync.py tests/coding_agent/test_semantic_tape_index.py -quv run ruff check tests/ui/test_session_manager_runtime.py && uv run ruff format --check tests/ui/test_session_manager_runtime.pygit diff --checkLocal review
989691eNo P1/P2 findings.Summary by CodeRabbit