Skip to content

test(memory): cover sqlite semantic recall path - #637

Merged
delete-cloud merged 4 commits into
mainfrom
test/sqlite-semantic-recall-e2e
Jun 27, 2026
Merged

delete-cloud merged 4 commits into
mainfrom
test/sqlite-semantic-recall-e2e

Conversation

@delete-cloud

@delete-cloud delete-cloud commented Jun 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add a task packet for the SQLite durable semantic recall proof slice
  • add a product-level regression covering SQLite durable TopicStore -> semantic rebuild -> later build_context recall
  • verify semantic recall renders the authoritative durable topic summary instead of backend hit text

Tests

  • uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q
  • uv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/plugins/test_semantic_memory.py -q
  • uv run pytest tests/ui/test_session_manager_runtime.py -k "selected_topic_store or semantic_topic_store or semantic_memory" -q
  • uv run pytest tests/coding_agent/test_sqlite_local_durable_fencing.py -k "selected_topic_store or topic_store or semantic" -q
  • uv run pytest tests/coding_agent/test_semantic_recall.py tests/coding_agent/test_semantic_sync.py tests/coding_agent/test_semantic_tape_index.py -q
  • uv run ruff check tests/ui/test_session_manager_runtime.py && uv run ruff format --check tests/ui/test_session_manager_runtime.py
  • git diff --check

Local review

  • subagent review found one P2 in the task packet review policy; fixed in 989691e
  • follow-up subagent review: No P1/P2 findings.

Summary by CodeRabbit

  • Chores
    • Updated review guidance for the design-sensitive workflow, adjusting which severity levels are considered actionable.
    • Kept the same fix-and-retest instruction after accepted findings.

Add a bounded task packet and product-level regression for the local SQLite durable semantic memory path: durable topic creation/finalization, semantic rebuild, and later build_context recall from authoritative topic data.

Verification:

- uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q

- uv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/plugins/test_semantic_memory.py -q

- uv run pytest tests/ui/test_session_manager_runtime.py -k 'selected_topic_store or semantic_topic_store or semantic_memory' -q

- uv run pytest tests/coding_agent/test_sqlite_local_durable_fencing.py -k 'selected_topic_store or topic_store or semantic' -q

- uv run pytest tests/coding_agent/test_semantic_recall.py tests/coding_agent/test_semantic_sync.py tests/coding_agent/test_semantic_tape_index.py -q

- uv run ruff check tests/ui/test_session_manager_runtime.py && uv run ruff format --check tests/ui/test_session_manager_runtime.py
Keep the meaningful backend_sentinel check and drop the unused stale backend string assertion flagged by review.

Verification:

- uv run pytest tests/ui/test_session_manager_runtime.py::test_sqlite_durable_semantic_rebuild_recalled_by_later_build_context_without_backend_hit_text -q

- uv run ruff check tests/ui/test_session_manager_runtime.py

- git diff --check
@coderabbitai

coderabbitai Bot commented Jun 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 09192bcf-c55f-4cea-8475-63efea5eaea7

📥 Commits

Reviewing files that changed from the base of the PR and between 6947471 and 239fab9.

📒 Files selected for processing (1)
  • coding-agent/.opencode/prompts/tasks/tape-memory-sqlite-recall-e2e-task-packet.md

📝 Walkthrough

Walkthrough

Updates the tape-memory SQLite recall task packet’s loop policy so reviewer findings are limited to P1/P2 instead of P0/P1, while the engineer fix-and-rerun instruction stays the same.

Changes

Loop policy prompt update

Layer / File(s) Summary
Loop policy threshold change
coding-agent/.opencode/prompts/tasks/tape-memory-sqlite-recall-e2e-task-packet.md
The loop policy text changes the allowed reviewer finding severity from P0/P1 to P1/P2 and keeps the engineer rerun instruction unchanged.

Estimated review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

I’m a little rabbit, quick and bright,
Hopping through prompts by morning light.
P1, P2—now that’s the tune,
Fix, rerun, and leap at noon. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and aligned with the PR’s SQLite semantic recall coverage, which is the main change area.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/sqlite-semantic-recall-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…recall-e2e

# Conflicts:
#	coding-agent/.opencode/prompts/tasks/tape-memory-sqlite-recall-e2e-task-packet.md
@delete-cloud
delete-cloud marked this pull request as ready for review June 27, 2026 04:27
@delete-cloud
delete-cloud merged commit 55fd2b2 into main Jun 27, 2026
2 checks passed
@delete-cloud
delete-cloud deleted the test/sqlite-semantic-recall-e2e branch June 27, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant