Skip to content

docs(adr): clarify semantic rebuild authority - #632

Merged
delete-cloud merged 1 commit into
mainfrom
docs/semantic-rebuild-boundaries
Jun 26, 2026
Merged

delete-cloud merged 1 commit into
mainfrom
docs/semantic-rebuild-boundaries

Conversation

@delete-cloud

@delete-cloud delete-cloud commented Jun 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Clarify ADR-0072 semantic rebuild authority: destructive full rebuilds require durable TopicStore plus reviewed-memory authority before clearing the derived backend.
  • Document that the current durable TopicStore authority is PG-only; local SQLite durable storage does not yet provide SQLiteTopicStore.
  • Record the landed semantic maintenance tests that enforce paged topic scans and no-topic-store-before-clear behavior.

Non-goals

  • Does not implement SQLiteTopicStore.
  • Does not enable [memory.semantic] by default.
  • Does not change runtime behavior.

Tests

  • uv run pytest tests/coding_agent/test_semantic_maintenance.py -q
  • uv run pytest tests/coding_agent/test_semantic_maintenance.py tests/coding_agent/test_topic_store.py tests/coding_agent/test_topic_layer_smoke.py -q
  • git diff --check

Review

  • Local subagent review: no P1/P2 findings.

Summary by CodeRabbit

  • Documentation
    • Clarified that full semantic rebuilds now require a complete, durable topic authority and will fail instead of proceeding from partial data.
    • Updated console usage guidance to note that the durable topic source is currently only available in PG-backed setups; non-PG fallback remains inspection-only.
    • Marked several semantic maintenance rebuild checks as completed in the implementation status checklist.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0160b585-e265-4401-a70b-04e313cbceb8

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa48fe and 771a08c.

📒 Files selected for processing (2)
  • coding-agent/docs/adr/0072-tape-memory-semantic-index-and-enable-switch.md
  • coding-agent/docs/topic_layer/USAGE.md

📝 Walkthrough

Walkthrough

The PR updates ADR-0072 to require complete authoritative topic and reviewed-memory sources before destructive semantic rebuilds, marks the implementation status and checklist items accordingly, and revises Topic Layer usage docs to state that durable TopicStore support is PG-only and SQLite fallback cannot rebuild semantics.

Changes

Semantic rebuild safety docs

Layer / File(s) Summary
ADR safety and checklist updates
coding-agent/docs/adr/0072-tape-memory-semantic-index-and-enable-switch.md
Adds the destructive rebuild prerequisite, the hard-fail rule when durable topic authority is unavailable, and the updated acceptance criteria and checklist status.
Usage doc fallback scope
coding-agent/docs/topic_layer/USAGE.md
States that SQLite does not provide SQLiteTopicStore, and the console fallback is inspection-only with semantic rebuild unavailable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I’m a rabbit with ears held high,
Hop-hop over rebuilds gone awry.
PG keeps the topic gate,
SQLite watches, cannot create. 🐇
I nibble docs, then thump away.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately summarizes the main change: clarifying semantic rebuild authority in documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/semantic-rebuild-boundaries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@delete-cloud
delete-cloud merged commit 1d76d8b into main Jun 26, 2026
2 checks passed
@delete-cloud
delete-cloud deleted the docs/semantic-rebuild-boundaries branch June 26, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant