Skip to content

Convert notes to remark/example divs: algebra - #91

Merged
dem-extra1 merged 7 commits into
mainfrom
claude/notes-to-divs-algebra
Oct 3, 2026
Merged

dem-extra1 merged 7 commits into
mainfrom
claude/notes-to-divs-algebra

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Part of #75

Why

A ::: notes div renders as unboxed plain text on the HTML page,
so a reader cannot see where the remark starts or ends,
and on slides it is hidden as speaker notes.
This PR converts the notes in the algebra subfiles to the theorem-type div that fits each one.

What changed

New divs, each with a {{< slidebreak >}} before it and a concrete example:

  • Remarks: rem-argmin-vs-minimum, rem-minimum-may-not-exist, rem-global-minimizer-argmin, rem-local-minimizer, rem-convex-chord-above-graph, rem-infimum-exists, rem-supremum-exists, rem-polynomial-nonzero, rem-summation-index, rem-square-of-a-difference
  • Examples: exm-cubic-not-convex, exm-convex-local-global, exm-polynomial-degree, exm-leading-coefficient, exm-exp-sum, exm-exp-difference, exm-sum-assoc
  • Definitions: def-fraction, def-rate, def-empty-sum

Other notes:

  • In _thm-exp-sum, _cor-exp-sum, and _thm-sum-assoc, the notes held the statement in words inside the theorem div; the wrapper is removed so the words show on the page.
    In _thm-sum-assoc the old sentence said "the order ... does not matter", which describes commutativity, not associativity; it now says it does not matter which pair you add first.
  • exm-convex-local-global is placed before thm-convex-local-global, as a motivating example, because _algebra.qmd includes the proof right after the theorem file and this slice does not edit the parent.
  • Sentences that only restated an exercise's answer were dropped.
  • def-rate drops the old note's "population size" wording: a count over a population size is a proportion, and the rate examples use time denominators.
  • Kept as ::: notes (source links or instructor-facing commentary): the Wikipedia credits in _def-ratio, _def-proportion, and _def-quotient, and _note-elementary-algebra-prereq.qmd (the author's reason for including the section, not math).

How verified

  • Every number recomputed in Python.
  • quarto render algebra.qmd --to html succeeds with no unresolved-crossref warnings, and every new id appears in _site/algebra.html.
  • git grep confirms the new ids are unique.
  • Adversarial self-review (subagent), five rounds, final verdict clean on d5f4ee3.

Known non-blocking items, left for follow-up: _def-sum-over-set.qmd restates the empty-sum convention and could cite @def-empty-sum; the remark examples for infimum and supremum overlap a little with exm-infimum and exm-supremum.

🤖 Generated with Claude Code

dem-extra1 and others added 5 commits October 3, 2026 00:31
A `::: notes` div renders as unboxed plain text on the HTML page,
so readers cannot see where the remark starts or ends,
and on slides it is hidden as speaker notes.
Convert each note in the algebra subfiles to a #rem-, #exm-, or #def- div
that fits its content, add a concrete example to each abstract statement,
and drop sentences that only restated an exercise's answer.
Notes that are only source links stay as speaker notes.

Part of #75.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Put the convexity example before its theorem, so the theorem
  stays next to its proof (included right after it in _algebra.qmd).
- Use enough digits in the exp-sum example that the product matches.
- Drop the forward reference to the degree definition from the
  polynomial remark; note the zero function's missing degree in the
  degree example instead.
- Make "rate" a def- div, like fraction, since the text defines it.

Part of #75.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the source comment back next to the convexity theorem,
name what fails without convexity, write out f(-2) in the cubic example,
and make the remark titles match their content.

Part of #75.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Narrow def-rate to time denominators, which is what both of its
examples show (a count over a population size is a proportion),
drop the zero-polynomial bullet that repeated rem-polynomial-nonzero,
and use four-digit factors in the exp-difference example.

Part of #75.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A rate is any quotient of two quantities; time denominators are the
common case, not the definition (the cited Wikipedia page lists
non-time rates, and the vector-calculus page speaks of a rate per
unit step). Also add the blank line before a div's closing fence.

Part of #75.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


This confirms it: state=OPEN, mergeable=MERGEABLE, 17 files / +242 −68, byte-identical to what was reviewed in both prior rounds (commits d5f4ee3 and 072906e1). The headRefOid (354457e) differs from the checkout's 6f5b9ea merge commit only because the latter is this job's throwaway merge-with-base commit — the actual PR content is unchanged.

Review: PR #91 — Convert notes to remark/example divs: algebra

Summary

No new content since the last review round. The prior review (posted 2026-10-03T08:13:06Z, here) examined this exact same 17-file, +242/−68 algebra diff and found it clean, after a first full round (posted 2026-10-03T08:07:37Z, here) independently re-verified the arithmetic, cross-reference integrity, div balance/nesting, style conventions, macro definitions, citations, and wordlist entries.

The commits added since the last-reviewed SHA (072906e1..6f5b9ea2) are:

None of these touch the algebra files this PR introduces; the saved diff (.claude-review-pr.diff) contains exactly the same 17 _subfiles/algebra/_*.qmd files as both prior rounds, confirmed by diff --git header count and by gh pr view's live stat (17 files, +242/−68) matching byte-for-byte. The linear-algebra _note-*.qmd files visible in git diff 072906e1..6f5b9ea2 are not part of this PR's diff against main — they came in from main's separate merge of #89/#90 — so they are out of scope for this review and were (and should continue to be) reviewed under PR #90 instead.

That prior verdict stands: no bugs, CLAUDE.md violations, or hallucinated references found.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "354457e5fc135b8fa52ccfb24eb5c5e376912b00",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Diff against main remains byte-identical to the previously reviewed 17-file algebra changeset in _subfiles/algebra.",
  "holistic_assessment": "Intervening merge commits only bring in the separately merged linear-algebra PR 90, outside this PR's scope and validation."
}

Reviewed commit: 354457e

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1903 (review) — run

@dem-extra1
dem-extra1 merged commit 46fadda into main Oct 3, 2026
16 checks passed
@dem-extra1
dem-extra1 deleted the claude/notes-to-divs-algebra branch October 3, 2026 08:28
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-03 01:34 PDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant