Skip to content

chore(actions): bump Morrison-Lab/gha/.github/workflows/claude-code-review.yml from 2 to 3 - #78

Merged
dem-extra1 merged 9 commits into
mainfrom
dependabot/github_actions/Morrison-Lab/gha/dot-github/workflows/claude-code-review.yml-3
Oct 3, 2026
Merged

dem-extra1 merged 9 commits into
mainfrom
dependabot/github_actions/Morrison-Lab/gha/dot-github/workflows/claude-code-review.yml-3

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 2, 2026

Copy link
Copy Markdown
Contributor

Bumps Morrison-Lab/gha/.github/workflows/claude-code-review.yml from 2 to 3.

Changelog

Sourced from Morrison-Lab/gha/.github/workflows/claude-code-review.yml's changelog.

Changelog

All notable changes to Morrison-Lab/gha are documented here.

This repo uses a moving major tag (v1) for consumers, following the r-lib/actions convention: the v1 tag moves forward as non-breaking fixes land, and consumers pin to @v1. Each release is also tagged with a full vX.Y.Z so a specific point can be pinned if needed. Breaking changes bump the major tag (v2, …) and are called out below with migration steps.

[Unreleased]

Changed

  • claude-code-review holds PRs to the SERG lab manual, opt-outable via a lab-manual input (#170, #171). The reusable review prompt evaluates a PR against the UCD-SERG lab manual -- coding style, coding practices (including function decomposition/length limits), and repository conventions -- in addition to correctness, so every R/Quarto consumer gets this check without needing a prompt-addendum (it mirrors the wording in this repo's own CLAUDE.md "Code review guidelines"). It is gated behind a lab-manual boolean (default true, so R/Quarto consumers are unchanged); set lab-manual: false for repos the R/tidyverse/Quarto-focused manual doesn't target (a pure GitHub Actions, shell, or docs repo) so the reviewer isn't handed irrelevant guidance.

  • claude-code-review grants the reviewer Bash(python3 <file>). The review agent could previously only trace a Python script's logic by eye, since its --allowedTools covered just the inline-comment tool plus the action's base allowlist (Read/Glob/Grep and narrow git-read Bash) -- no way to actually execute the script under review (rme#970). Scoped to running an existing file under the checkout (-c/-m denied, so inline/module code execution stays blocked) -- same-repo PRs give this job CLAUDE_CODE_OAUTH_TOKEN/ANTHROPIC_API_KEY as secrets, so unrestricted python3:* would have been a real capability widening beyond the existing git-read-only sandbox, not just a git-push question. It can now verify a script's behavior instead of guessing from source alone (#154).

  • claude-code-review now honors an explicit review request on a draft PR. A dispatched review (an @claude review comment routed here by claude.yml, claude.yml's post-push re-dispatch, the issue-trigger draft PR, or a manual dispatch) already bypassed the workflow's draft-skip if: gate, but the code-review skill's own don't-review-drafts stop condition still made the agent refuse ("currently a draft … I will not proceed"), so an explicit @claude review on a draft produced a refusal instead of a review. The dispatched-run prompt now overrides that stop condition so an explicitly-requested review runs even on a draft. Automatic pull_request reviews still skip drafts (their if: gate never reaches the agent on a draft), so this only widens the dispatched path.

... (truncated)

Commits
  • a6c64fc Merge pull request #980 from Morrison-Lab/claude/review-checks-read-comment
  • e129706 Drop the stale check-pr-fully-clean.py rationale from checks: read
  • 8bc0490 Merge pull request #979 from Morrison-Lab/claude/review-self-reference-loop
  • d45da90 Put one sentence per line in the changelog fragment
  • de70465 Stop the reviewer gating its verdict on its own in-flight check (#978)
  • e26a9b0 Merge pull request #976 from Morrison-Lab/claude/fix-preview-highlight-hang
  • 140550d test(preview): two blank lines between top-level tests, not three
  • 3ff89da fix(preview): the real cause is <p matching <pre in ELEMENT_RE
  • 61d5a5b fix(preview): make highlighter docs and diagnostics match the code
  • 98388c3 fix(preview): bound HTML change highlighting on htmlwidget pages (closes #975)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

…eview.yml

Bumps [Morrison-Lab/gha/.github/workflows/claude-code-review.yml](https://github.com/morrison-lab/gha) from 2 to 3.
- [Changelog](https://github.com/Morrison-Lab/gha/blob/main/CHANGELOG.md)
- [Commits](Morrison-Lab/gha@v2...v3)

---
updated-dependencies:
- dependency-name: Morrison-Lab/gha/.github/workflows/claude-code-review.yml
  dependency-version: '3'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 2, 2026
dem-extra1 and others added 2 commits October 3, 2026 00:01
gha's claude-code-review.yml@v3 requests checks: read in its reviewer
job (gha#833). A reusable workflow cannot get more permissions than
its caller grants, so this bump hit startup_failure until the caller
grants it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No job in gha's claude-code-review.yml@v3 requests id-token: write;
its header says the grant is deliberately omitted and the reviewer
uses github.token instead of the App-token exchange the comment cited.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dem-extra1

Copy link
Copy Markdown
Contributor

The v3 bump hit startup_failure because v3's claude-review job requests checks: read (gha#833) and this caller did not grant it; a called job cannot get more permissions than its caller grants. Pushed two commits:

  • aa71c59 grants checks: read on the review job.
  • ca09d4e drops id-token: write, which no v3 job requests (v3's header says it is deliberately omitted), from an adversarial-review nit.

An adversarial subagent review checked every v3 job's permissions: block, required inputs and secrets against this caller and found nothing else missing. Note that v3 also installs posit-dev skills by default (use-posit-skills), a behaviour change rather than a breakage. The review run itself will still fail until the org CLAUDE_CODE_OAUTH_TOKEN is rotated (current runs get 401 OAuth access token is invalid).

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ot-github/workflows/claude-code-review.yml-3
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ot-github/workflows/claude-code-review.yml-3
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ot-github/workflows/claude-code-review.yml-3
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ot-github/workflows/claude-code-review.yml-3
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ot-github/workflows/claude-code-review.yml-3
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ot-github/workflows/claude-code-review.yml-3
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Confirmed once more: checks: read is still required by the gha v3 reviewer job (gha#833, line 623), and id-token: write is correctly omitted since the job forwards github_token: github.token rather than exercising the App-token OIDC exchange (lines 596-602). This exactly matches the PR's diff.

No .qmd/R content, no build artifacts, no scope creep in this PR's actual diff.

The prior review verdict — posted 2026-10-03T08:38:15Z, confirming all five earlier rounds — still stands: Ready for merge. This round changes nothing in that assessment.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "cfb7ad0f6b6ef2e3f5c95f9e772164a595ae94bd",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only changed path, .github/workflows/claude-code-review.yml, still swaps id-token: write for checks: read and bumps the reusable workflow to v3, matching gha v3's documented startup_failure fix with no other failure mode present.",
  "holistic_assessment": "PR net diff remains one file and four lines per gh pr view, so integration with gha v3's input contract, regression risk, and review scope are unchanged from all six already-confirmed prior rounds."
}

Reviewed commit: cfb7ad0

Reviewed commit: cfb7ad0

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1884 (review) — run

@dem-extra1
dem-extra1 merged commit 53419ac into main Oct 3, 2026
16 checks passed
@dem-extra1
dem-extra1 deleted the dependabot/github_actions/Morrison-Lab/gha/dot-github/workflows/claude-code-review.yml-3 branch October 3, 2026 08:51
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-03 01:58 PDT

dem-extra1 added a commit to Morrison-Lab/gha that referenced this pull request Oct 12, 2026
…s: read (#1046)

A caller that does not grant checks: read gets startup_failure on the
Dependabot bump to @V3, and the PR then shows no review check at all.
Say so where the permission is documented, and that the grant belongs in
the bump PR itself (measured on Morrison-Lab/mds#78).

Part of #1006.


Claude-Session: https://claude.ai/code/session_01N4nd3xZSoq2TLWoyEVCBgh

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: dem-extra1 <112029334+dem-extra1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant