Skip to content

Define superset and strict superset directly - #72

Merged
dem-extra1 merged 7 commits into
mainfrom
claude/superset-direct
Oct 3, 2026
Merged

dem-extra1 merged 7 commits into
mainfrom
claude/superset-direct

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Requested by Ezra · project thread

Part of #49. This PR fixes only the two definitions the issue names. The issue also asks for a sweep of all definitions, and that stays open.

Before: "B is a superset of A if A is a subset of B." That restates subset and has no content of its own. Strict superset was defined the same way, through strict subset.

After:

  • Superset: "every element of $A$ is an element of $B$."
  • Strict superset: "$B$ is a superset of $A$ and $B \neq A$." This is the same shape as the existing strict-subset definition.
  • A note under each one says it is equivalent to the subset form and keeps that link. The superset note has the example $\set{1, 2, 3} \supseteq \set{1, 3}$.

How: two subfile edits under _subfiles/sets-functions/. sets-functions.qmd renders locally, and the anchors are unchanged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV


Generated by Claude Code

Superset now says what it means (every element of A is in B) instead
of restating subset, and strict superset combines superset with B != A,
matching strict subset. Notes keep the link to the subset forms.
Part of mds#49 (only these two definitions).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
@d-morrison d-morrison self-assigned this Oct 2, 2026
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

@claude review

The earlier review was skipped for quota, which has now reset.


Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👀 Picked up by workflow run #37004967857. Setup runs first; Claude itself responds after that.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

review / require-clean-verdict fails only on the stray .github/pkg.lock that the @claude auto-commit added in 1a12a9e. The content passed review. Removing the file is waiting on Ezra's OK, because my session's permission check blocked the deletion. Once it is removed, I will re-request review.


Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

An @claude run auto-committed this pak lockfile. No workflow uses it,
and every review flagged it as out of scope. Ezra asked for its removal
in the project thread (cmsg_014QLd5McmoUEgMPRiXeVnjSFzGqSZJz1ZXkSXd8tAX95g).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

The notes after the superset and strict superset definitions were
`::: notes` divs, which the HTML page shows as plain text. Each is now
a #rem- div with a concrete example.

Requested by Ezra (cmsg_014QLd5McmoUEgMPRiXeVnjSVYNcX981EiAKNSnuKoUjGS).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

The rendered preview shows the #rem- divs are remark callouts. In pr-preview/pr-72/sets-functions.html on gh-pages, the new div renders as <div id="rem-superset-subset" class="proof remark"> with the title "Remark 1 (Superset and subset)". It sits inside the same callout-body-container wrapper as the existing {.remark .notes} remarks on that page, such as the strict-subset remark. Quarto assigns the remark class to a #rem- div itself, so callouty-theorem.lua's proof_types entry applies. mds#70's #rem-distance-from-origin renders the same way.

The slide change is intended. Ezra asked for these notes to be in divs instead of ::: notes (speaker notes do not show on the HTML page), so each remark is now a visible, numbered and linkable block. The slidebreak before it follows the repository rule of one slidebreak before each theorem-type div.

The older {.remark .notes} remarks will be converted to the same form under mds#75.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@dem-extra1

Copy link
Copy Markdown
Contributor

Independent check of the rebuttal above: the current preview at pr-preview/pr-72/sets-functions.html renders both new divs as <div id="rem-superset-subset" class="proof remark" and <div id="rem-strict-superset-subset" class="proof remark", so the 17:16 UTC finding (that #rem- divs never become remark callouts) does not hold. This PR needs only a fresh review; the review workflow is currently failing with 401 OAuth access token is invalid, so that has to wait for the token to be rotated.

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I have what I need — the most recent verdict-bearing comment URL is https://github.com/Morrison-Lab/mds/pull/72#issuecomment-5967114583 (posted 2026-10-03T08:18:59Z). Now writing the final review.

Review: PR #72 — Define superset/strict superset directly

Scope check confirmed. The saved diff (/home/runner/work/mds/mds/.claude-review-pr.diff) is 49 lines touching exactly two files: _subfiles/sets-functions/_def-superset.qmd and _subfiles/sets-functions/_def-strict-superset.qmd. I independently diffed cb03fc2d (the commit reviewed in the prior round) against the current head f04140c9 restricted to those two paths and got zero output — the content is byte-for-byte identical to what was already reviewed. The much larger diffstat quoted in this task's "what changed since last round" section (61 files, index.qmd, inst/WORDLIST, the _subfiles/algebra, linear-algebra, measures, notation, vector-calc rewrites, the workflow bump) is entirely the result of merging main into this branch to pick up unrelated PRs (#78, #88, #89, #90, #91, #93) — none of that content originated on this branch, and it is not part of this PR's actual diff.

Re-verification of the unchanged content:

  • _def-superset.qmd:6 — "every element of $A$ is an element of $B$" is the correct direct definition of superset, mirroring _def-subset.qmd's phrasing with roles reversed.
  • _def-strict-superset.qmd:9-11 — "$B$ is a superset of $A$ and $B \neq A$" correctly mirrors the existing _def-strict-subset.qmd:7 pattern ("$A$ is a subset of $B$ and $A \neq B$").
  • Both new rem-* divs' cross-references (#def-subset, #def-strict-subset) resolve: both anchors exist (_subfiles/sets-functions/_def-subset.qmd:1, _subfiles/sets-functions/_def-strict-subset.qmd:1).
  • Worked examples are mathematically correct: ${1,2,3} \supseteq {1,3}$; ${1,2,3} \supsetneq {1,3}$ because ${1,2,3}$ contains $2$ which ${1,3}$ lacks.
  • {{< slidebreak >}} placement and heading-level structure (####) match the established sibling pattern in _def-strict-subset.qmd.
  • "superset" needs no inst/WORDLIST entry (it isn't flagged by the spell checker as an unusual term, unlike domain-specific coinages), consistent with no wordlist changes being part of this diff.

No CLAUDE.md violations, no SERG lab-manual concerns (this diff contains no R code or package structure changes), no build-hygiene issues (no _site//_freeze/ artifacts touched), and no CI-workflow contract changes in this PR's actual diff.

This confirms the prior review's verdict — see the 2026-10-03T08:18:59Z review, which found the content clean and was withheld only pending CI completion (build-deploy and the review's own check run). That round's content assessment stands unchanged since no commits have altered the two files under review since then.

Verdict

Ready for merge — content is unchanged and clean (re-verified against the actual diff, not the merge-inflated range), and I have no basis in this read-only run to independently confirm live CI/check-run completion state beyond what's already been reported in prior rounds; that mechanical gate should be rechecked by whatever process reads check-run status for this review.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "43d1d9d60504eacb8210abff0af440f6f480bdf2",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Diffed cb03fc2d against f04140c9 restricted to the two touched definition files and found zero byte differences, confirming no new defect was introduced in this round.",
  "holistic_assessment": "The apparent 61-file diffstat is scope creep from merging main, not this branch's own changes, so requirement, regression, and scope validation all reduce to the previously-reviewed two-file content."
}

Reviewed commit: 43d1d9d

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3189 (review) — run

@dem-extra1

Copy link
Copy Markdown
Contributor

Intent to merge: this PR is fully clean on head 43d1d9d6 (check-pr-fully-clean.py exit 0). The Claude review at 08:54 UTC on 2026-10-03 says Ready for merge, and the head's merge-base is the current main tip 53419ac5. The author's last push to the branch was 2026-10-02 17:19 UTC; the two later pushes are this session's update-branch calls. I will squash-merge it in five minutes under the session's merge grant unless someone replies here to hold off.

Posted by Claude Code (AI agent) --- not written by a human.

@dem-extra1
dem-extra1 merged commit e408e67 into main Oct 3, 2026
16 checks passed
@dem-extra1
dem-extra1 deleted the claude/superset-direct branch October 3, 2026 09:20
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-03 02:26 PDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants