Repository navigation
Define superset and strict superset directly - #72
Conversation
Superset now says what it means (every element of A is in B) instead of restating subset, and strict superset combines superset with B != A, matching strict subset. Notes keep the link to the subset forms. Part of mds#49 (only these two definitions). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
This comment has been minimized.
This comment has been minimized.
|
@claude review The earlier review was skipped for quota, which has now reset. Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
👀 Picked up by workflow run #37004967857. Setup runs first; Claude itself responds after that. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
An @claude run auto-committed this pak lockfile. No workflow uses it, and every review flagged it as out of scope. Ezra asked for its removal in the project thread (cmsg_014QLd5McmoUEgMPRiXeVnjSFzGqSZJz1ZXkSXd8tAX95g). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The notes after the superset and strict superset definitions were `::: notes` divs, which the HTML page shows as plain text. Each is now a #rem- div with a concrete example. Requested by Ezra (cmsg_014QLd5McmoUEgMPRiXeVnjSVYNcX981EiAKNSnuKoUjGS). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The rendered preview shows the The slide change is intended. Ezra asked for these notes to be in divs instead of The older Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Independent check of the rebuttal above: the current preview at Posted by Claude Code (AI agent) --- not written by a human. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Claude finished review — View run I have what I need — the most recent verdict-bearing comment URL is Review: PR #72 — Define superset/strict superset directlyScope check confirmed. The saved diff ( Re-verification of the unchanged content:
No CLAUDE.md violations, no SERG lab-manual concerns (this diff contains no R code or package structure changes), no build-hygiene issues (no This confirms the prior review's verdict — see the 2026-10-03T08:18:59Z review, which found the content clean and was withheld only pending CI completion ( VerdictReady for merge — content is unchanged and clean (re-verified against the actual diff, not the merge-inflated range), and I have no basis in this read-only run to independently confirm live CI/check-run completion state beyond what's already been reported in prior rounds; that mechanical gate should be rechecked by whatever process reads check-run status for this review. Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "43d1d9d60504eacb8210abff0af440f6f480bdf2",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Diffed cb03fc2d against f04140c9 restricted to the two touched definition files and found zero byte differences, confirming no new defect was introduced in this round.",
"holistic_assessment": "The apparent 61-file diffstat is scope creep from merging main, not this branch's own changes, so requirement, regression, and scope validation all reduce to the previously-reviewed two-file content."
}Reviewed commit: 43d1d9d |
|
Intent to merge: this PR is fully clean on head Posted by Claude Code (AI agent) --- not written by a human. |
|
Requested by Ezra · project thread
Part of #49. This PR fixes only the two definitions the issue names. The issue also asks for a sweep of all definitions, and that stays open.
Before: "B is a superset of A if A is a subset of B." That restates subset and has no content of its own. Strict superset was defined the same way, through strict subset.
After:
How: two subfile edits under
_subfiles/sets-functions/.sets-functions.qmdrenders locally, and the anchors are unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01QvbjcNvjASan2nmbyGaooV
Generated by Claude Code