Repository navigation
Leave the Report a Problem options to support plugins - #2595
Merged
Merged
Conversation
Support had Report Issue, Submit Bug Report (added by LoopSupport) and Export Critical Event Logs next to each other. The ways to report a problem now belong to support plugins; DIY Loop's live in LoopSupport behind a single Report a Problem row. Loop's report form, submitter and local export screen move to LoopSupport, and Loop provides its critical event log export through SupportUIDelegate.criticalEventLogExportView().
Contributor
Test✅ backport new method for requesting support from next-dev to dev ConfigurationStart with LoopWorkspace dev branch, commit
Build onto an iOS 27 SE 3rd gen phone. New Support DisplayAfter this build, grab screenshots of the Loop Settings, Support section with new rows. Report a Problem
Submit to Developers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2594 to dev.
Support had Report Issue, Submit Bug Report (added by LoopSupport) and Export Critical Event Logs next to each other, and local export was a button at the bottom of the developer report form. The ways to report a problem now belong to support plugins; DIY Loop's live in LoopSupport (LoopKit/LoopSupport#40), behind a single Report a Problem row.
In Loop:
CommandResponseViewController.generateDiagnosticReport) is removed.SupportUIDelegate.criticalEventLogExportView()(Let support plugins provide Report a Problem and critical event logs LoopKit#661).Differences from next-dev:
generateIssueReportalready returns the full diagnostic report, so no change was needed there.Merge order: LoopKit/LoopKit#661 and LoopKit/LoopOnboarding#37 first, then this and LoopKit/LoopSupport#40 together.
Testing:
LoopWorkspacescheme build; Loop tests pass.