Repository navigation
Submit issue reports to the LoopKit developers; require iOS 17.6 - #2586
Merged
Merged
Conversation
The project-level 15.1 setting overrode Loop.xcconfig, so the app still targeted iOS 15.1. Remove it and raise Loop.xcconfig to 17.6, which matches next-dev and the plugins that already require it.
Backport of #2585 from next-dev. Settings > Support > Report Issue now opens one screen where the person either submits a report to ingest.loopkit.org/v1/issues or exports Loop's diagnostic report locally, which opens the existing issue report screen. A submitted report has a description, optional title and screenshots. It is anonymous unless the person fills in a name, email, Zulip or GitHub contact, and the analytics device ID is never sent. Build and device details (version, build, branch, revisions, device model, OS, pump and CGM model) are listed on the screen and sent with every report. Loop's diagnostic report is attached as text by default; the toggle says it contains health data. Photos other than PNG are converted to JPEG. dev has no build customizations list, so that context key is left out. The diagnostic report and the pump and CGM models come from the settings delegate, since dev's settings view model has no device manager.
Contributor
TestPoint to this PR for Loop when building LoopWorkspace dev, v3.14.10, commit ✅ Successfully sent a report to the developers: FM61Y94K
There is no reason why the customizations could not included in this as they are in next-dev. |
marionbarker
approved these changes
Oct 17, 2026
marionbarker
left a comment
marionbarker
left a comment
Contributor
There was a problem hiding this comment.
Approve by test - assuming the Loop Report with ID FM61Y94K was transmitted as expect.
The Customization script adds the empty *.loopcustomization files at the top level of LoopWorkspace for all customizations.
Backport of #2577 from next-dev. capture-build-details.sh records each *.loopcustomization file that the LoopWorkspace customization script adds, the diagnostic report lists them, and an issue report sends them as "customizations" with the other build details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2585 from next-dev, plus raising the minimum iOS version to 17.6.
Require iOS 17.6. A project-level
IPHONEOS_DEPLOYMENT_TARGET = 15.1overrode the 16.2 inLoop.xcconfig, so dev still targeted iOS 15.1. This removes the project-level setting and setsLoop.xcconfigto 17.6. That matches next-dev and the plugins that already require 17.6 (OmnipodKit, EversenseKit, MedtrumKit), and LoopDocs already lists iOS 17.6 as the minimum. The new screen's PhotosPicker and two-argumentonChangeneed iOS 16 and 17 respectively.Report Issue. Settings > Support > Report Issue opens one screen. From there the person either submits a report to
ingest.loopkit.org/v1/issues, or taps Export Locally Instead to open the existing issue report screen.IssueReportSubmitter.swiftandSendIssueReportView.swiftare the same as on next-dev.SettingsViewModelhas no device manager, so the diagnostic report and the pump and CGM models come throughSettingsViewModelDelegate, whichStatusTableViewControllerimplements withDeviceDataManager.*.loopcustomizationfiles the LoopWorkspace customization script adds, the diagnostic report lists them, and reports send them ascustomizations.Testing