Skip to content

Restore prediction margins after landscape rotation - #2573

Merged
ps2 merged 2 commits into
LoopKit:next-devfrom
damonbayer:dmb/fix-rotation-2477
Oct 13, 2026
Merged

ps2 merged 2 commits into
LoopKit:next-devfrom
damonbayer:dmb/fix-rotation-2477

Conversation

@damonbayer

@damonbayer damonbayer commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Prediction rows can retain the landscape margin after returning to portrait. Remove the explicit separator-to-content-margin assignments from prediction input rows, chart cell configuration, and the legacy potential carb-entry cell. UIKit then updates margins for the current safe area and readable width through the existing constraints.

Addresses #2477. The related #1610 verification is summarized below. Companion fixes: LoopKit #645 and RileyLinkKit #22.

Before and after

Predicted Glucose in the full Loop app, on iPhone 17 Pro simulator with iOS 26.5, after portrait → landscape → portrait. The original rows retain the landscape inset; the fixed rows restore their portrait alignment. The app was unconfigured, so the graph is intentionally empty. Capture details and baseline revisions.

Before: next-devAfter: this change
Before prediction fixAfter prediction fix

Validation and #1610 coverage

  • Full LoopWorkspace simulator build passed with Xcode 27.
  • Predicted Glucose passed the rotation round trip and opening in landscape before returning to portrait.
  • Production Carbohydrates storyboard/cell fixtures with synthetic values restored label bounds within 0.5 pt; no additional Carbohydrates change was needed.
  • Production Therapy Settings views showed the grouped background in both landscape safe areas in a synthetic fixture. The original physical-device-only report still needs physical-device confirmation.
  • The Bolus comment remains unresolved: its explicit portrait restriction is unchanged. This PR does not claim to close all of Various Screen Rotation Issues in loop-dev #1610.
  • Source audit covered every screen family and shared pump/CGM/service/onboarding components. Connected-device screens were not all exercised live.
  • No new test sources or test-project references are included.

Companion PRs

@damonbayer
damonbayer marked this pull request as ready for review October 13, 2026 02:45
@ps2
ps2 merged commit 20d597f into LoopKit:next-dev Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants