Repository navigation
Restore prediction margins after landscape rotation - #2573
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prediction rows can retain the landscape margin after returning to portrait. Remove the explicit separator-to-content-margin assignments from prediction input rows, chart cell configuration, and the legacy potential carb-entry cell. UIKit then updates margins for the current safe area and readable width through the existing constraints.
Addresses #2477. The related #1610 verification is summarized below. Companion fixes: LoopKit #645 and RileyLinkKit #22.
Before and after
Predicted Glucose in the full Loop app, on iPhone 17 Pro simulator with iOS 26.5, after portrait → landscape → portrait. The original rows retain the landscape inset; the fixed rows restore their portrait alignment. The app was unconfigured, so the graph is intentionally empty. Capture details and baseline revisions.
Validation and #1610 coverage
Companion PRs