Repository navigation
Integrate rotation layout fixes across Loop components - #533
Closed
damonbayer wants to merge 1 commit into
Closed
damonbayer wants to merge 1 commit into
damonbayer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Loop, LoopKit, and RileyLinkKit submodule pins to the coordinated fixes for margins that remain inset after portrait → landscape → portrait, plus setup footers that keep their portrait height in landscape.
Companion draft PRs, all targeting
next-dev:This integration PR pins the proposed commits so the combined change can be built and reviewed. After companion PRs merge, refresh the pins if their final commit IDs change.
Before and after
Full Loop app on iPhone 17 Pro simulator, iOS 26.5, after portrait → landscape → portrait. Before, prediction rows retain the landscape inset; after, they restore their portrait alignment. The app is unconfigured and the graph intentionally empty. Each companion PR includes its own component comparisons. Capture details and baseline revisions.
Validation
Full LoopWorkspace simulator build passed with Xcode 27. Direct before/after captures reproduced the original prediction inset and verified the fixed alignment. Synthetic component fixtures verified shared settings cells, RileyLink device rows, and setup footer sizing.
The screen audit documents checks for Loop #2477 and Loop #1610. The physical-device-only Therapy Settings report still requires physical-device confirmation, and Bolus remains portrait-restricted. No new tests are included.