Skip to content

Restore prediction margins after landscape rotation #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ps2 merged 2 commits into from
Oct 13, 2026
Merged

Restore prediction margins after landscape rotation #2573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a86e83
Restore prediction row margins after rotation
damonbayer Oct 13, 2026
e8be264
Remove rotation layout audit document
damonbayer Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Loop/View Controllers/PredictionTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ class PredictionTableViewController: LoopChartsTableViewController, Identifiable
switch Section(rawValue: indexPath.section)! {
case .charts:
let cell = tableView.dequeueReusableCell(withIdentifier: ChartTableViewCell.className, for: indexPath) as! ChartTableViewCell
cell.contentView.layoutMargins.left = tableView.separatorInset.left
cell.setChartGenerator(generator: { [weak self] (frame) in
return self?.charts.chart(atIndex: 0, frame: frame)?.view
})
Expand Down
7 changes: 0 additions & 7 deletions Loop/Views/PotentialCarbEntryTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@ class PotentialCarbEntryTableViewCell: UITableViewCell {
@IBOutlet weak var valueLabel: UILabel!
@IBOutlet weak var dateLabel: UILabel!

override func layoutSubviews() {
super.layoutSubviews()

contentView.layoutMargins.left = separatorInset.left
contentView.layoutMargins.right = separatorInset.left
}

override func awakeFromNib() {
super.awakeFromNib()

Expand Down
7 changes: 0 additions & 7 deletions Loop/Views/PredictionInputEffectTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ class PredictionInputEffectTableViewCell: UITableViewCell {

@IBOutlet weak var subtitleLabel: UILabel!

override func layoutSubviews() {
super.layoutSubviews()

contentView.layoutMargins.left = separatorInset.left
contentView.layoutMargins.right = separatorInset.left
}

var enabled: Bool = true {
didSet {
if enabled {
Expand Down