Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added NDLA.no - #6681

Closed
Foorack wants to merge 3 commits into
EFForg:masterfrom
Foorack:patch-1
Closed

Foorack wants to merge 3 commits into
EFForg:masterfrom
Foorack:patch-1

Conversation

@Foorack

@Foorack Foorack commented Aug 30, 2016

Copy link
Copy Markdown

NDLA is the main digital learning platform for higher education schools in Norway.

NDLA is the main digital learning platform for higher education schools in Norway.
@Hainish Hainish added the top-1m label Aug 30, 2016
@jeremyn

jeremyn commented Sep 10, 2016

Copy link
Copy Markdown
Contributor

Please add more subdomains, see here.

Comment thread src/chrome/content/rules/ndla.no.xml Outdated
<target host="ndlap4.ndla.no" />
<target host="ndlap4.ndla.no" />
<target host="ndlap4.ndla.no" />
<target host="ndlap4.ndla.no" />

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More subdomains added :D
Jk, will fix in a sec.

@jeremyn jeremyn self-assigned this Sep 11, 2016
@Foorack

Foorack commented Sep 14, 2016

Copy link
Copy Markdown
Author

@jeremyn Updated.

@jeremyn

jeremyn commented Sep 14, 2016 •

Copy link
Copy Markdown
Contributor

EDIT: checklist moved here to new pull request.

@Foorack

Foorack commented Sep 15, 2016

Copy link
Copy Markdown
Author

How can you find so many domains? Using Google search and other tools I find most but there is still some on your list that I can't figure out how you found. Anyways, I updated the list and made a new pull. This should be the last pull I have lost write access to so hopefully this shoudl't happen in the future.

I read your post regarding how involved the ruleset reviewer should be and I am sorry for the extra work. I will do a better pre-research next time.

@Foorack

Foorack commented Sep 15, 2016

Copy link
Copy Markdown
Author

Updated pull #6882.

@Foorack Foorack closed this Sep 15, 2016
@jeremyn

jeremyn commented Sep 15, 2016 •

Copy link
Copy Markdown
Contributor

I have two main approaches to finding domains.

  1. Google search trick. Note that sometimes Google doesn't show all domains even when you think it should. For example if I remember correctly, static. randomly appeared at the end of some elimination query when I didn't expect it.
  2. When I try sites, I usually have the Firefox developer tools Network tab open and watch what is loaded. If any new sites jump out at me, I might note them down. For example loading https://ndla.no you can see calls to https://auth.ndla.no , https://cdntest-a.ndla.no and others.

Also if I happen across some new domain while reviewing, I might note it. For example, when I go to https://arkiv.ndla.no , I get the below mismatch message which reveals https://ndlap4cpanelhost01v.ndlap4.ndla.no :

arkiv.ndla.no uses an invalid security certificate.

The certificate is only valid for the following names:
  ndlap4cpanelhost01v.ndlap4.ndla.no, www.ndlap4cpanelhost01v.ndlap4.ndla.no

Error code: SSL_ERROR_BAD_CERT_DOMAIN

Another thing you can do is look for some sort of sitemap, like this one for eBay. I don't use these when I'm reviewing though.

I think it's important to be realistic and not go overboard looking. I don't want you to feel like making rulesets is a huge burden or weird puzzle. I'm not aggressively trying to find domains that you missed. I do the Google search trick, watch sites Ioad, and sometimes make notes of new domains that I discover. If the domain looks really "internal" to the site then I might skip it. For example if I go to https://ndlat4vhosts02v.ndlap4.ndla.no , I get a mismatch message that includes:

The certificate is only valid for the following names:
  auth.test.ndla.no, auth.test2.ndla.no, www.auth.test2.ndla.no, www.auth.test.ndla.no

I don't think it's necessary to look into domains like www.auth.test2.ndla.no. Another example, I don't know how you found https://ndlap4revproxy01v.ndlap4.ndla.no but if you used some kind of script or hunted through DNS listings then that's too much.

Thanks for your work. It does help us the more thorough you are but I don't want you to feel so self-conscious or nervous about it that you stop contributing or feel bad about contributing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants