Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

created rule for dji.com - #7358

Merged
Hainish merged 5 commits into
EFForg:masterfrom
schmiedecker:master
Jan 18, 2017
Merged

Hainish merged 5 commits into
EFForg:masterfrom
schmiedecker:master

Conversation

@schmiedecker

Copy link
Copy Markdown
Contributor

No description provided.

@jeremyn

jeremyn commented Oct 16, 2016 •

Copy link
Copy Markdown
Contributor

Thanks for the ruleset. This is a big site, and there's a lot more than what you included in f29563c. Please make the following changes. For the various "Mark as" items, I mean add a comment to the top like you see in this example. Please let me know if you have any questions, I want to make sure you understand every change you're making.

Mark as Incomplete certificate chain:

Mark as Invalid certificate:

Mark as Mixed content:

Mark as Refused:

Mark as Secure connection failed:

Mark as Time out:

Mark as Unable to connect:

Add target:

Also:

  • Change the filename Dji.com.xml to DJI.xml
  • Change the ruleset name from DJI.xml to DJI
  • Add the following to Qbox.me.xml:
    <target host="dn-dji-videos.qbox.me" />
        <!-- Loaded by https://we.dji.com -->
        <test url="http://dn-dji-videos.qbox.me/cloud/0a2370e7e2e3e65aac7006322918eaaa/720.mp4" />
  • In all cases where there is a list of domains, sort them in alphabetical order starting from the top level domain at the right reading left, moving ^ and www to the top of their group. For example:
example.com
www.example.com
a.example.com
www.a.example.com
b.a.example.com
b.example.com
example.net
www.example.net
a.example.net

@jeremyn jeremyn self-assigned this Oct 16, 2016
@jeremyn

jeremyn commented Nov 2, 2016

Copy link
Copy Markdown
Contributor

@schmiedecker There's been no progress on this since my last comment. If for any reason you don't want to, or can't, make the requested changes yourself, please feel free to select the "Allow edits from maintainers" option and I'll make the changes myself.

@schmiedecker

Copy link
Copy Markdown
Contributor Author

woah - sure thing, change your way. I'd be happy to allow edits from maintainers, and the checkmark is set.

Can you maybe point me to ressources / comment on how to 1) identify all those subdomains, 2) verify that they have the same content and 3) somewhat build the ruleset semi-automatically? I found the domain and some generic domains using random surfing, I'm sure there are better ways ...

@jeremyn

jeremyn commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

Thanks.

For your questions, see #6681 (comment) , #6912 , and #7277 . Unfortunately some manual review is still needed.

@jeremyn jeremyn closed this Nov 3, 2016
@jeremyn jeremyn reopened this Nov 3, 2016
@jeremyn

jeremyn commented Nov 4, 2016

Copy link
Copy Markdown
Contributor

@fuglede @Hainish @J0WI I've made my own changes to this pull request, so could one of you please review this? Also, because there are multiple contributors, please don't squash-and-merge.

@jeremyn

jeremyn commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Pinging @gloomy-ghost for the previous comment too.

@jeremyn jeremyn removed their assignment Dec 5, 2016
@Hainish

Hainish commented Jan 17, 2017

Copy link
Copy Markdown
Member

Checking on this now

@Hainish

Hainish commented Jan 18, 2017

Copy link
Copy Markdown
Member

superseded by #8217

@Hainish Hainish closed this Jan 18, 2017
@Hainish
Hainish merged commit 86537ad into EFForg:master Jan 18, 2017
@jeremyn jeremyn mentioned this pull request Jan 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants